Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump patch version to 2.0.8 for filepath dependency update #58

Closed
wants to merge 1 commit into from

Conversation

jsl
Copy link
Member

@jsl jsl commented Feb 13, 2025

Bump patch version to allow for filepath dependency update fix. See: #57

Copy link
Collaborator

@Alex0jk Alex0jk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approving, left a comment explaining how we are approaching releases and versioning in the library.

@@ -1,5 +1,5 @@
name: atomic-write
version: 0.2.0.7
version: 0.2.0.8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not how we are currently handling versioning in this library, we are using this library as a testing ground for semantic release with the semantic-release-hackage plugin: https://github.com/stackbuilders/semantic-release-hackage

We will need to update the readme to make this clear, basically, will create an issue for that and track it here.

To make semantic-release work we need commits that have start with chore, feat, fix, etc, here: https://github.com/semantic-release/semantic-release

@@ -1,5 +1,5 @@
name: atomic-write
version: 0.2.0.7
version: 0.2.0.8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what we would have here is version 0.0.0.0 or something like that as we are not release with this version.

@felixminom
Copy link

Given that this library uses semantic release and that Alexander closed his PR. We could close this one, right?

@jsl jsl closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants