Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update cabal upload for docs job #50

Closed
wants to merge 1 commit into from

Conversation

dalejo96
Copy link
Contributor

Updated the cabal upload job in the release workflow for using username and password because token is not working.

@dalejo96
Copy link
Contributor Author

@JoseLion do you mind adding secrets to the repo?
HACKAGE_USERNAME
HACKAGE_PASSWORD

@dalejo96 dalejo96 requested review from JoseLion and Alex0jk March 14, 2024 20:25
Copy link
Member

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalejo96 we should stick to the API key to prevent security vulnerabilities. I left a comment with more info 🙂

@JoseLion
Copy link
Member

JoseLion commented Mar 14, 2024

@dalejo96, now that I think of it, it'd be better to have a separate workflow to upload the docs. We can call this workflow in publish.yml and it'd be also possible to dispatch it manually when needed. Let's catch up in this

@Alex0jk
Copy link
Collaborator

Alex0jk commented Jun 21, 2024

Will close this PR in favor of: #52

@Alex0jk Alex0jk closed this Jun 25, 2024
@Alex0jk Alex0jk deleted the chore/ci-docs-job branch June 25, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants