Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sematic-release): Set up semantic-release with Hackage plugin #43

Merged
merged 7 commits into from
Mar 11, 2024

Conversation

dalejo96
Copy link
Contributor

@dalejo96 dalejo96 commented Feb 16, 2024

I have created the semantic-release support for this repo with the following:

  • Add package.json to manage semantic-release and semantic-release-hackage versions.
  • Use latests yarn
  • Add .nvmrc file
  • Update the CI workflow with the node installation
  • Add releaserc file for plugin configuration

We need to change to a conventional commit format PR #41 for testing this workflow.

Please, review

Copy link
Collaborator

@Alex0jk Alex0jk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
just left a suggestion to do some more deletions

@Alex0jk
Copy link
Collaborator

Alex0jk commented Feb 22, 2024

@dalejo96 is the yarn-4.1.0.cjs file needed here?

Copy link
Member

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. I left a few comments, let me know if you have any questions 🙂

@dalejo96
Copy link
Contributor Author

dalejo96 commented Feb 27, 2024

@dalejo96 is the yarn-4.1.0.cjs file needed here?

Yes that is required by yarn

@dalejo96 dalejo96 requested review from JoseLion and Alex0jk February 27, 2024 19:06
Copy link
Collaborator

@Alex0jk Alex0jk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Alex0jk Alex0jk merged commit 247e471 into main Mar 11, 2024
3 checks passed
@Alex0jk Alex0jk deleted the feat-add-semantic-release branch March 11, 2024 16:50
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants