Add boundaries for dependencies in cabal file #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update GH Actions to also build with GHC 9
sestrella
reviewed
Oct 24, 2023
Remove boundaries in test package
jpvillaisaza
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Looks good.
hspecseems to be missing version constraints.- The Cabal file is missing adding a
cabal-version. I don't think that's a problem, but maybe it can be updated (in a separate pull request). - The
stack.yamlfile also looks outdated. If that's still working, it should be updated (could be a separate pull request as well).
|
Will open a follow up pull request to update the cabal-version and stack.yaml files |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add boundaries to the project dependencies.
The added boundaries are based on the base boundary and the general use of other dependencies with each other.
Solves #36