Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all contributors #34

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Add all contributors #34

merged 2 commits into from
Sep 18, 2023

Conversation

Alex0jk
Copy link
Collaborator

@Alex0jk Alex0jk commented Sep 5, 2023 •
edited
Loading

No description provided.

@Alex0jk Alex0jk self-assigned this Sep 5, 2023
@Alex0jk Alex0jk force-pushed the chore/add-all-contributors branch from 6434d4f to f5f5651 Compare September 8, 2023 21:00
JoseLion
JoseLion approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@JoseLion JoseLion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I left a suggestion to add a badge, but not a blocker, it's entirely up to you 🙂

README.md
@@ -38,6 +38,41 @@ Then you can use the atomicWriteFile function that accepts a FilePath and a Byte
See the
[Haddock documentation](http://hackage.haskell.org/package/atomic-write).

## Contributors ✨
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alex0jk, you can also add a badge on top that will automatically update with the total number of contributors. I think it's on all-contributors documentation, but you can check this PR from Diego to review how it looks 😬

@Alex0jk Alex0jk merged commit e5dfe67 into master Sep 18, 2023
@Alex0jk Alex0jk deleted the chore/add-all-contributors branch September 18, 2023 21:05
@Alex0jk Alex0jk mentioned this pull request Sep 18, 2023
Closed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseLion JoseLion JoseLion approved these changes

@CristhianMotoche CristhianMotoche CristhianMotoche approved these changes

Assignees

@Alex0jk Alex0jk

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alex0jk @JoseLion @CristhianMotoche