Migrate to GitHub actions #31
Conversation
Alex0jk
force-pushed
the
gh-actions-setup
branch
from
dc03f51 to
474a7ba
Compare
There was a problem hiding this comment.
@Alex0jk nice job so far! I would just suggest updating the status badges on the README file and also adding a section talking about the release process, if I understand this workflow correctly a maintainer would need to create a GH release before publishing a new version to Hackage. Am I right?
Alex0jk
force-pushed
the
gh-actions-setup
branch
from
474a7ba to
5805f4d
Compare
Alex0jk
force-pushed
the
gh-actions-setup
branch
from
5805f4d to
7c1d2c4
Compare
Alex0jk
force-pushed
the
gh-actions-setup
branch
from
d260835 to
f1c054a
Compare
There was a problem hiding this comment.
@Alex0jk Looks good. Although, we don't have an executable on atomic-write so we don't need many of the steps that you defined in the draft.yml file. Also, can you give a look at the README.md? It seems the diagram is not rendering correctly. Thanks!
.github/workflows/README.md
Outdated
| ```mermaid | ||
| graph LR; | ||
| event[GH Event]-->|on push|Build; | ||
| event-->|tag created|Draft; | ||
| Draft-->|create draft release|End; | ||
| event-->|release published|Release; | ||
| Release-->|upload artifacts to Hackage (release candidate)|End; | ||
| Build-->End; | ||
| ``` |
There was a problem hiding this comment.
@Alex0jk It seems this diagram has some kind of error. It cannot be rendered. Can you double check that please?
.github/workflows/draft.yml
Outdated
| - uses: addnab/docker-run-action@v3 | ||
| with: | ||
| image: utdemir/ghc-musl:v24-ghc922 | ||
| options: -v ${{ github.workspace }}:/mnt | ||
| run: | | ||
| cd /mnt | ||
| sh build.static.sh | ||
|
|
||
| - name: Change owner before compression | ||
| run: sudo chown $USER:$USER atomic-write |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Add basic setup for GitHub actions :
release.ymlanddraft.ymlThis is for #30