Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(native): Add toBeDisabled #140

Merged
merged 22 commits into from
Mar 17, 2025
Merged

feat(native): Add toBeDisabled #140

merged 22 commits into from
Mar 17, 2025

Conversation

suany0805
Copy link
Contributor

@suany0805 suany0805 commented Nov 6, 2024 •
edited by kdquistanchala
Loading

This PR adds the toBeDisabled and toBeEnabled matchers for React Native

@suany0805 suany0805 force-pushed the feat/native-to-be-disabled branch from c61ba82 to 190ce45 Compare November 12, 2024 20:35
@suany0805 suany0805 force-pushed the feat/native-to-be-disabled branch from 4c514fe to 2259962 Compare November 26, 2024 20:48
@suany0805 suany0805 force-pushed the feat/native-to-be-disabled branch from 2259962 to 72efbf8 Compare November 26, 2024 20:59
@suany0805 suany0805 force-pushed the feat/native-to-be-disabled branch from 5817dc1 to 1e2a9c3 Compare November 28, 2024 21:07
@suany0805 suany0805 force-pushed the feat/native-to-be-disabled branch from 1e2a9c3 to 5fbe42a Compare November 28, 2024 21:23
@suany0805 suany0805 marked this pull request as ready for review December 2, 2024 14:36
@suany0805 suany0805 requested a review from JoseLion as a code owner December 2, 2024 14:36
@JoseLion JoseLion changed the title feat(Native) - Native toBeDisabled feat(native): Add toBeDisabled Dec 4, 2024
JoseLion
JoseLion reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! There's a few things to address but I think we're on the right path in general. Let me know if you have any questions 🙂

packages/native/test/lib/ElementAssertion.test.tsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing tests for .not.toBeDisabled() and not.ToBeEnabled(). The messaging is different, so having some unit tests is good. I'd test them together with the not inverted test cases to make things simpler, check the core package for examples 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi José! I have reviewed the comment and had to modify the logic of toBeEnabled() to correctly account for the error messages that should be displayed when using .not.toBeDisabled() and not.ToBeEnabled(). I have also added the tests, but please let me know your thoughts. Thanks

@suany0805 suany0805 force-pushed the feat/native-to-be-disabled branch from 0022d85 to 898721a Compare December 23, 2024 21:34
JoseLion
JoseLion approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left a suggestions for the JSDoc, but feel free to merge once you check that. 🎉

@kdquistanchala kdquistanchala merged commit 27d0001 into main Mar 17, 2025
4 checks passed
@JoseLion JoseLion deleted the feat/native-to-be-disabled branch March 18, 2025 14:47
@JoseLion
Copy link
Member

@all-contributors please add @suany0805 for code

@allcontributors allcontributors bot mentioned this pull request Mar 18, 2025
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoseLion

I've put up a pull request to add @suany0805! 🎉

@JoseLion
Copy link
Member

@all-contributors please add @kdquistanchala for review

@allcontributors allcontributors bot mentioned this pull request Mar 18, 2025
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoseLion

I've put up a pull request to add @kdquistanchala! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdquistanchala kdquistanchala kdquistanchala left review comments

@JoseLion JoseLion JoseLion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suany0805 @JoseLion @kdquistanchala @lopenchi