fix: ignore templates node_modules
#198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
templates/*/node_modulesshould be ignored #189Fixes issues where users would see
jsh: permission deniederrors ifsrc/templates/*/node_moduleswere present on host machines' file system. TutorialKit would copy thosenode_modulesto webcontainers and try to run them. Thesenode_modulesmay contain platform specific binaries that fail to run on webcontainers (non-wasm builds).Adds
node_modulesto be ignored insrc/templates. At this point the change is hard-coded and not configurable. See #189 (comment).I'll create a follow-up feature request that would allow including
node_modules, so that tutorial authors could include pre-optimized dependencies in their templates. This is lower priority task compared to #189 that users are running into now.