Skip to content

feat: Support OPA role mapping #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 78 commits into from
Feb 26, 2025
Merged

feat: Support OPA role mapping #582

merged 78 commits into from
Feb 26, 2025

Conversation

Maleware
Copy link
Member

@Maleware Maleware commented Dec 23, 2024

Description

Contains:

relies on https://github.com/stackabletech/docker-images/tree/feature/superset-opa-integration

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@Maleware Maleware self-assigned this Dec 23, 2024
Maleware and others added 27 commits December 23, 2024 14:53

Verified

This commit was signed with the committer’s verified signature.
labrenbe Benedikt Labrenz

Verified

This commit was signed with the committer’s verified signature.
labrenbe Benedikt Labrenz

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
labrenbe Benedikt Labrenz

Verified

This commit was signed with the committer’s verified signature.
labrenbe Benedikt Labrenz

Verified

This commit was signed with the committer’s verified signature.
labrenbe Benedikt Labrenz

Verified

This commit was signed with the committer’s verified signature.
labrenbe Benedikt Labrenz

Verified

This commit was signed with the committer’s verified signature.
labrenbe Benedikt Labrenz

Verified

This commit was signed with the committer’s verified signature.
labrenbe Benedikt Labrenz

Verified

This commit was signed with the committer’s verified signature.
labrenbe Benedikt Labrenz

Verified

This commit was signed with the committer’s verified signature.
razvan Razvan-Daniel Mihai
sbernauer
sbernauer previously approved these changes Feb 26, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks. LGTM when tests pass

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Co-authored-by: Sebastian Bernauer <[email protected]>

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Co-authored-by: Sebastian Bernauer <[email protected]>
sbernauer
sbernauer previously approved these changes Feb 26, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass

@sbernauer sbernauer changed the title feat: Enable opa role mapping feat: Support OPA role mapping Feb 26, 2025

Verified

This commit was signed with the committer’s verified signature.
razvan Razvan-Daniel Mihai
sbernauer
sbernauer previously approved these changes Feb 26, 2025

Verified

This commit was signed with the committer’s verified signature.
razvan Razvan-Daniel Mihai

Verified

This commit was signed with the committer’s verified signature.
razvan Razvan-Daniel Mihai
@razvan
Copy link
Member

razvan commented Feb 26, 2025

OpenShift test 🟢

--- PASS: kuttl (315.53s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/opa_superset-4.1.1_opa-latest-1.0.1_openshift-true (314.71s)
PASS

@razvan
Copy link
Member

razvan commented Feb 26, 2025

@razvan razvan enabled auto-merge February 26, 2025 18:21
@razvan razvan requested a review from sbernauer February 26, 2025 18:21
@razvan razvan added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 9c8a7d5 Feb 26, 2025
17 checks passed
@razvan razvan deleted the feature/opa-role-mapping branch February 26, 2025 18:44
@lfrancke
Copy link
Member

Can you please link docs if we have any (sounds like we should) and add a release note snippet?

@sbernauer
Copy link
Member

@Techassi Techassi added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 27, 2025
@lfrancke
Copy link
Member

@Techassi @labrenbe ping re: release notes please (even if they are already in the final ones)

@Techassi
Copy link
Member

The final release notes @NickLarsenNZ and I came up with are:

* Apache Superset: Support Open Policy Agent role mapping. See #582.

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/25.3.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants