This repository was archived by the owner on Feb 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
[Merged by Bors] - Add demo data-warehouse-iceberg-trino-spark #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltesander
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. LGTM!
It kept running over the weekend. We are now at
|
bf9d717
to
9538515
Compare
@maltesander could you please do another round reviewing the docs? |
…stackabletech/stackablectl into demo-data-warehouse-iceberg-trino-spark
maltesander
suggested changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just english nitpicking!
docs/modules/ROOT/pages/demos/data-warehouse-iceberg-trino-spark.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/demos/data-warehouse-iceberg-trino-spark.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/demos/data-warehouse-iceberg-trino-spark.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/demos/data-warehouse-iceberg-trino-spark.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/demos/data-warehouse-iceberg-trino-spark.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/demos/data-warehouse-iceberg-trino-spark.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/demos/data-warehouse-iceberg-trino-spark.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/demos/data-warehouse-iceberg-trino-spark.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/demos/data-warehouse-iceberg-trino-spark.adoc
Outdated
Show resolved
Hide resolved
dc3c913
to
958f46f
Compare
…rk.adoc Co-authored-by: Malte Sander <[email protected]>
…rk.adoc Co-authored-by: Malte Sander <[email protected]>
Co-authored-by: Malte Sander <[email protected]>
1 task
maltesander
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Many many thanks! |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
## Description Needs a larger k8s cluster! I use IONOS k8s with 9x 4 cores (8 threads), 20GB ram and 30GB hdd disk Maybe we can also offer a smaller variant later on. Otherwise business as usual. From feature-branch run `stackablectl --additional-stacks-file stacks/stacks-v1.yaml --additional-releases-file releases.yaml --additional-demos-file demos/demos-v1.yaml demo install data-warehouse-iceberg-trino-spark` I'm not happy with some parts but i think an iterative approach is best: * Shared bikes are currently not streamed into Kafka (instead on-time job) * Some high-volume real-time datasource would be great. Currently we use the water levels and duplicate them to get higher volumes. * Some sort of Upsert or Deletion usecases would be great. But probably not on the large datasets as for our wallet ^^ * Better Dashboards. The current one were thrown together quickly * I would like to partitions the water_level measurements by day but run into apache/iceberg#5625. There might be ways around by using a dedicated Spark context for compaction but we can easily adopt the partitioning after the issue gets fixed. Sorting during rewrites did cost performance during compaction and did not provide real benefits for my intial measurements. Disabled for now. * As always tracked my findings in https://github.com/stackabletech/stackablectl/issues/128 To get to the Spark UI `kubectl port-forward $(kubectl get pod -o name | grep 'spark-ingest-into-warehouse-.*-driver') 4040`
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Needs a larger k8s cluster! I use IONOS k8s with 9x 4 cores (8 threads), 20GB ram and 30GB hdd disk
Maybe we can also offer a smaller variant later on.
Otherwise business as usual. From feature-branch run
stackablectl --additional-stacks-file stacks/stacks-v1.yaml --additional-releases-file releases.yaml --additional-demos-file demos/demos-v1.yaml demo install data-warehouse-iceberg-trino-spark
I'm not happy with some parts but i think an iterative approach is best:
To get to the Spark UI
kubectl port-forward $(kubectl get pod -o name | grep 'spark-ingest-into-warehouse-.*-driver') 4040
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information