Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Oct 29, 2025

Description

Part of stackabletech/issues#791

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Oct 29, 2025
@razvan razvan requested a review from a team October 29, 2025 14:20
@razvan razvan enabled auto-merge October 29, 2025 14:20
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Oct 29, 2025
@adwk67 adwk67 requested review from adwk67 and removed request for a team October 30, 2025 11:35
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 30, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit 5ebd1d3 Oct 30, 2025
17 checks passed
@razvan razvan deleted the fix/getting-started-pre-25.11.0 branch October 30, 2025 12:29
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Oct 30, 2025
@sbernauer sbernauer mentioned this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

3 participants