[Merged by Bors] - OpenShift compatibility #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
This allows the operator installation to pass the pod security admission and complete successfuly.
Setting runAsGroup automatically makes runAsUser required in non OpenShift environments.
And add runAsUser to Jobs preapring dependency volumes.
|
bors try |
tryBuild succeeded: |
maltesander
reviewed
Sep 1, 2022
There was a problem hiding this comment.
On kind i have flaky tests on a fresh cluster (minio is ready but connection refused when trying to connect). Could not reproduce that if the images are already there (which should not make a difference actually).
There is some duplication between the single tests (e.g. 00-serviceaccount.yaml.j2). Not sure if this is isolated on purpose?
LGTM otherwise.
|
lgtm - all tests run successfully on CRC/OS running on local machine. |
Moved nodeSelector property to the spark-examples and delete the node-selector test.
maltesander
approved these changes
Sep 2, 2022
|
bors merge |
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125
Jenkins run: https://ci.stackable.tech/job/spark-k8s-operator-it-custom/32/