Skip to content

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 25, 2025

Description

Fixup of #602.
That PR added a check and uncovered a bug in krb5-provision-keytab returning a wrong exit code.

As I originally though the bug was related to CLI arguments, I bumped op-rs. Doesn't really belong here, but also doesn't hurt.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer requested review from soenkeliebau and a team August 25, 2025 12:14
@sbernauer sbernauer self-assigned this Aug 25, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Aug 25, 2025
soenkeliebau
soenkeliebau previously approved these changes Aug 26, 2025
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this, but it looks good to me.
Some unrelated stuff in here I guess, which confused me briefly..

@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 26, 2025
@sbernauer sbernauer added this pull request to the merge queue Aug 26, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Aug 26, 2025
Merged via the queue into main with commit 1bb670c Aug 26, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/krb5-provision-keytab-exit-status branch August 26, 2025 16:16
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants