Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow the specification of additional trust roots #573

Merged
merged 13 commits into from
Mar 21, 2025

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Mar 18, 2025

Description

Allow the specification of additional trust roots in autoTls SecretClasses

Closes #570

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@siegfriedweber siegfriedweber self-assigned this Mar 18, 2025
@siegfriedweber siegfriedweber force-pushed the feat/additional-trust-roots branch from a8dac72 to af490f1 Compare March 18, 2025 15:04
@siegfriedweber siegfriedweber marked this pull request as ready for review March 20, 2025 10:47
@siegfriedweber siegfriedweber requested a review from nightkr March 20, 2025 10:48
@siegfriedweber siegfriedweber requested a review from nightkr March 21, 2025 14:09
nightkr
nightkr previously approved these changes Mar 21, 2025
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in theory, happy to merge if tests pass

@siegfriedweber siegfriedweber added this pull request to the merge queue Mar 21, 2025
Merged via the queue into main with commit dce2902 Mar 21, 2025
17 checks passed
@siegfriedweber siegfriedweber deleted the feat/additional-trust-roots branch March 21, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy additional CAs with the autoTls backend
4 participants