Skip to content

feat: Allow the specification of additional trust roots #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 21, 2025

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Mar 18, 2025

Description

Allow the specification of additional trust roots in autoTls SecretClasses

Closes #570

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@siegfriedweber siegfriedweber self-assigned this Mar 18, 2025
@siegfriedweber siegfriedweber force-pushed the feat/additional-trust-roots branch from a8dac72 to af490f1 Compare March 18, 2025 15:04
@siegfriedweber siegfriedweber marked this pull request as ready for review March 20, 2025 10:47
@siegfriedweber siegfriedweber requested a review from nightkr March 20, 2025 10:48
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Mar 20, 2025
@siegfriedweber siegfriedweber moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 21, 2025
@siegfriedweber siegfriedweber requested a review from nightkr March 21, 2025 14:09
nightkr
nightkr previously approved these changes Mar 21, 2025
Copy link
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in theory, happy to merge if tests pass

@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Mar 21, 2025
@siegfriedweber siegfriedweber added this pull request to the merge queue Mar 21, 2025
Merged via the queue into main with commit dce2902 Mar 21, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy additional CAs with the autoTls backend
4 participants