feat: Add format-specific annotations to override secret file names #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Blocked on 25.3.0 release.
A check to prevent path traversal was introduced in a7718e0, integration tests still need to be added.
This PR adds support to customize the secret file names using
secrets.stackable.tech
annotations on the volume. The following attributes were added:secrets.stackable.tech/format.tls-pkcs12.keystore-name
secrets.stackable.tech/format.tls-pkcs12.truststore-name
secrets.stackable.tech/format.tls-pem.cert-name
secrets.stackable.tech/format.tls-pem.key-name
secrets.stackable.tech/format.tls-pem.ca-name
This came up in demo testing during the 25.3.0 SPD release, see stackabletech/demos#157 (comment).
This PR adds a new test dimension which is used in the
tls
tests. All adjusted tests pass: