Skip to content

TrustStore CRD #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 96 commits into
base: main
Choose a base branch
from
Open

TrustStore CRD #557

wants to merge 96 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jan 29, 2025

Description

Fixes #410.

rust/p12 is imported from hjiayz/p12@9983420 (fff63d1), can't really do much about CLA failures from before that point (and beyond that I've kept the changes fairly minimal to enable our use case). Discussed at https://stackable-workspace.slack.com/archives/C033A863YPL/p1741869321744189.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

hjiayz and others added 30 commits April 11, 2020 09:46
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Drop ring dependency and update RustCrypto
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
update crypto dependencies
@nightkr nightkr marked this pull request as ready for review March 17, 2025 15:12
@nightkr nightkr requested a review from a team March 17, 2025 15:23
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following questions are open:

I did not review the complete p12 directory, but only the changes to v0.6.3.

nightkr added 3 commits April 10, 2025 12:27
This is currently only used by the TrustStore controller, but would also
be a step towards exposing the same info for the CSI endpoints in the future.
@nightkr nightkr requested a review from siegfriedweber April 11, 2025 13:19
@nightkr
Copy link
Member Author

nightkr commented Apr 14, 2025

Ah didn't see #410 (comment) - replying to that in there.

Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr nightkr enabled auto-merge April 14, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow customers to request CA cert (e.g. for external clients)
7 participants