Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually disable credential cache for krb5 provisioner #490

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Aug 14, 2024

Description

KRB5CCNAME=MEMORY will store the cache in a file named MEMORY, KRB5CCNAME=MEMORY: will store the cache in memory (as intended).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

No tasks being tracked yet.

Reviewer

Acceptance

`KRB5CCNAME=MEMORY` will store the cache in a file named `MEMORY`, `KRB5CCNAME=MEMORY:` will store the cache in memory (as intended).
@nightkr nightkr marked this pull request as ready for review August 14, 2024 11:43
@nightkr
Copy link
Member Author

nightkr commented Aug 14, 2024

Haven't tested it here, but ran into the same issue on stackabletech/opa-operator#524 and the same change fixed it there.

@nightkr nightkr requested a review from a team August 14, 2024 11:45
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@nightkr nightkr added this pull request to the merge queue Aug 15, 2024
Merged via the queue into main with commit adb3d3d Aug 15, 2024
31 checks passed
@nightkr nightkr deleted the nightkr-patch-1 branch August 15, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants