-
-
Notifications
You must be signed in to change notification settings - Fork 1
chore(template): Add Helm helper for telemetry env vars #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLarsenNZ
previously approved these changes
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Release NoteAll operators now have access to these telemetry related Helm values. These are the defaults: telemetry:
consoleLog:
enabled: true
level: null
format: null
fileLog:
enabled: false
level: null
rotationPeriod: null
maxFiles: null
otelLogExporter:
enabled: false
level: null
endpoint: null
otelTraceExporter:
enabled: false
level: null
endpoint: null |
NickLarsenNZ
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
scheduled-for/25.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#639
Depends on
file_log_max_files
operator-rs#1010This adds the
telemetry.envVars
Helm helper to create a list of environment variables passed on the.telemetry
values.Example
Given these values form the Helm
values.yaml
filethe rendered env block in the Deployment looks like
Default values will be set according to the design laid out in the tracking issue.