Skip to content

chore(stackable-operator): Re-introduce #950 #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 31, 2025

Conversation

Techassi
Copy link
Member

Caution

This PR must not be merged before the SDP 25.3.0 release.

This PR re-introduces changes from #950 which were reverted in #987.

@Techassi Techassi self-assigned this Mar 19, 2025
@Techassi Techassi moved this to Development: Track in Stackable Engineering Mar 19, 2025
@Techassi Techassi moved this from Development: Track to Development: In Progress in Stackable Engineering Mar 31, 2025
@Techassi Techassi marked this pull request as ready for review March 31, 2025 12:29
@Techassi Techassi moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Mar 31, 2025
NickLarsenNZ
NickLarsenNZ previously approved these changes Mar 31, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor change to the deprecation notice

@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 31, 2025
@Techassi Techassi requested a review from NickLarsenNZ March 31, 2025 14:54
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi enabled auto-merge March 31, 2025 14:56
@Techassi Techassi added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 91beab2 Mar 31, 2025
10 checks passed
@Techassi Techassi deleted the chore/deprecate-initialize-logging branch March 31, 2025 15:04
@NickLarsenNZ NickLarsenNZ moved this from Development: In Review to Development: Done in Stackable Engineering Apr 1, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants