feat(stackable-operator/s3connection): Add region field defaulting to us-east-1 #959
+80
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLarsenNZ
changed the title
NickLarsenNZ
force-pushed
the
feat/s3-connection-region
branch
from
742dcd8 to
46f9d75
Compare
|
A decision item has been raised: https://github.com/stackabletech/decisions/issues/46 |
…complex to cater to the various use-cases: 1. Using S3 buckets from within AWS (users can choose to auto-discover via IMDS) 2. Using S3 buckets from outside AWS (users can choose the default, or set an optimal region based on the clients location). 3. Not using AWS S3 buckets, eg: MinIO or IONOS (users can ignore setting the field and the default region will be set to keep the AWS SDK happy, even though the region is not used for bucket operations).
NickLarsenNZ
force-pushed
the
feat/s3-connection-region
branch
from
46f9d75 to
a8f87a8
Compare
…the struct is already representing the "region"
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Techassi <[email protected]>
Done in d7bab12 |
Techassi
approved these changes
Feb 21, 2025
This was referenced Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/docker-images#971.
Definition of Done Checklist