Skip to content

fix(helm): Give RBAC permission to delete Services #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 5, 2025

Description

Should fix
failed to apply Service.v1./listener-lab1-hdfs-namenode-default-0.stack-lab: failed to apply patch: unable to patch resource "listener-lab1-hdfs-namenode-default-0": ApiError: services "listener-lab1-hdfs-namenode-default-0" is forbidden: cannot set an ownerRef on a resource you can't delete: , <nil>: Forbidden (ErrorResponse { status: "Failure", message: "services \"listener-lab1-hdfs-namenode-default-0\" is forbidden: cannot set an ownerRef on a resource you can't delete: , <nil>", reason: "Forbidden", code: 403 }): services "listener-lab1-hdfs-namenode-default-0" is forbidden: cannot set an ownerRef on a resource you can't delete: , <nil>: Forbidden

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

Verified

This commit was signed with the committer’s verified signature.
sbernauer Sebastian Bernauer

Verified

This commit was signed with the committer’s verified signature.
sbernauer Sebastian Bernauer
@sbernauer sbernauer self-assigned this Mar 5, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Mar 5, 2025
@sbernauer sbernauer requested review from razvan and adwk67 March 5, 2025 13:52
@sbernauer
Copy link
Member Author

sbernauer commented Mar 5, 2025

Paging @razvan and @adwk67, as this also effects the olm package

@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 5, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Waiting for Review in Stackable Engineering Mar 5, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 5, 2025
@adwk67
Copy link
Member

adwk67 commented Mar 5, 2025

I'm just checking the creation of the Openshift manifests....

Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit c1f49eb Mar 5, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/rbac-delete-service branch March 5, 2025 15:03
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Mar 10, 2025
@sbernauer sbernauer changed the title fix(docker): Give RBAC permission to delete Services fix(helm): Give RBAC permission to delete Services Mar 10, 2025
@lfrancke
Copy link
Member

Could you please add a release note snippet in the form "Previously, . With this release, ."

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Mar 20, 2025
@sbernauer
Copy link
Member Author

sbernauer commented Mar 20, 2025

I don't think this needs a mention in the platform release notes, so I'd say the changelog is sufficient.

Give RBAC permission to delete Services, which is needed to set an ownerRef on already existing Services ([#283]).

If we want to change the wording, we need to change it in the changelog, should I raise a PR?

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants