Skip to content

feat!: Use stackable-telemetry #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 8, 2025
Merged

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Apr 1, 2025

Description

Part of stackabletech/issues#639.

Warning

This PR adds a bunch of lines now that will be collapsed into a single line later (with stackabletech/operator-rs#1001). This has been decided so that we unblock others working on operator-rs changes.

  • Replace print_startup_string with structured event
  • Use stackable_telemetry::Tracing
    • BREAKING: File log directory is now set by ROLLING_LOGS.
    • In this PR, if the operator is deployed via Helm, rolling file logs will be disabled because the chart doesn't yet support additional args/env vars. A follow up PR will cover this.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@NickLarsenNZ NickLarsenNZ self-assigned this Apr 1, 2025
@NickLarsenNZ NickLarsenNZ marked this pull request as draft April 1, 2025 17:31
@NickLarsenNZ NickLarsenNZ changed the title at: Use stackable-telemetry feat: Use stackable-telemetry Apr 1, 2025
@NickLarsenNZ NickLarsenNZ changed the title feat: Use stackable-telemetry feat!: Use stackable-telemetry Apr 8, 2025
@NickLarsenNZ NickLarsenNZ marked this pull request as ready for review April 8, 2025 08:48
@NickLarsenNZ NickLarsenNZ moved this to Development: Waiting for Review in Stackable Engineering Apr 8, 2025
@NickLarsenNZ NickLarsenNZ enabled auto-merge April 8, 2025 08:59
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit d4be6c3 Apr 8, 2025
16 of 17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the feat/stackable-telemetry branch April 8, 2025 09:08
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Apr 8, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants