Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Readiness probe to use broker listener #833

Merged
merged 18 commits into from
Mar 20, 2025
Merged

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Mar 12, 2025

Description

Fixes #829

Openshift 🟢

--- PASS: kuttl (389.17s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/configuration_kafka-latest-3.7.2_zookeeper-latest-3.9.2_openshift-true (42.14s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.2_openshift-true_krb5-1.21.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit (83.44s)
        --- PASS: kuttl/harness/upgrade_zookeeper-3.9.2_upgrade_old-3.7.1_upgrade_new-3.9.0_use-client-tls-true_use-client-auth-tls-true_openshift-true (146.49s)
        --- PASS: kuttl/harness/smoke_kafka-3.9.0_zookeeper-3.9.2_use-client-tls-true_openshift-true (81.28s)
        --- PASS: kuttl/harness/tls_kafka-3.9.0_zookeeper-latest-3.9.2_use-client-tls-true_use-client-auth-tls-true_openshift-true (141.93s)
        --- PASS: kuttl/harness/cluster-operation_kafka-latest-3.7.2_zookeeper-latest-3.9.2_openshift-true (100.81s)
        --- PASS: kuttl/harness/logging_kafka-3.9.0_zookeeper-latest-3.9.2_openshift-true (86.17s)
        --- PASS: kuttl/harness/delete-rolegroup_kafka-3.9.0_zookeeper-latest-3.9.2_openshift-true (51.26s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@adwk67 adwk67 marked this pull request as ready for review March 12, 2025 10:33
@adwk67 adwk67 self-assigned this Mar 12, 2025
@siegfriedweber siegfriedweber self-requested a review March 12, 2025 12:32
@adwk67
Copy link
Member Author

adwk67 commented Mar 20, 2025

Re-ran the affected tests:

--- PASS: kuttl (247.55s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false_krb5-1.21.1_kerberos-realm-CLUSTER.LOCAL_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-cluster-internal (79.07s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false_krb5-1.21.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-cluster-internal (86.13s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false_krb5-1.21.1_kerberos-realm-CLUSTER.LOCAL_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-external-unstable (79.17s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false_krb5-1.21.1_kerberos-realm-CLUSTER.LOCAL_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-external-stable (80.31s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false_krb5-1.21.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-external-unstable (80.82s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false_krb5-1.21.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-external-stable (80.61s)
PASS

@adwk67 adwk67 requested a review from siegfriedweber March 20, 2025 14:09
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 3cc252f Mar 20, 2025
16 of 17 checks passed
@adwk67 adwk67 deleted the fix/readiness-probe branch March 20, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Kcat probe returns false positives when used with kerberized Kafka
4 participants