feat: Hive listener integration #605

Maleware · 2025-05-27T12:57:07Z

Description

Adds listener Support

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

Author

Changes are OpenShift compatible
CRD changes approved
CRD documentation for all fields, following the style guide.
Helm chart can be installed and deployed operator works
Integration tests passed (for non trivial changes)
Changes need to be "offline" compatible

Reviewer

Code contains useful comments
Code contains useful logging statements
(Integration-)Test cases added
Documentation added or updated. Follows the style guide.
Changelog updated
Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

Feature Tracker has been updated
Proper release label has been added
Roadmap has been updated

Maleware · 2025-05-28T07:51:52Z

=== NAME  kuttl
    harness.go:403: run tests finished
    harness.go:510: cleaning up
    harness.go:567: removing temp folder: ""
--- PASS: kuttl (2381.48s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_postgres-12.5.6_hive-3.1.3_openshift-false_s3-use-tls-false (109.29s)
        --- PASS: kuttl/harness/resources_hive-4.0.1_openshift-false (25.30s)
        --- PASS: kuttl/harness/kerberos-hdfs_postgres-12.5.6_hive-4.0.1_hdfs-latest-3.4.1_zookeeper-latest-3.9.3_krb5-1.21.1_openshift-false_kerberos-realm-PROD.MYCORP_kerberos-backend-mit (174.61s)
        --- PASS: kuttl/harness/kerberos-hdfs_postgres-12.5.6_hive-4.0.0_hdfs-latest-3.4.1_zookeeper-latest-3.9.3_krb5-1.21.1_openshift-false_kerberos-realm-PROD.MYCORP_kerberos-backend-mit (173.43s)
        --- PASS: kuttl/harness/kerberos-hdfs_postgres-12.5.6_hive-3.1.3_hdfs-latest-3.4.1_zookeeper-latest-3.9.3_krb5-1.21.1_openshift-false_kerberos-realm-PROD.MYCORP_kerberos-backend-mit (191.31s)
        --- PASS: kuttl/harness/kerberos-s3_postgres-12.5.6_hive-4.0.1_krb5-1.21.1_openshift-false_s3-use-tls-true_kerberos-realm-PROD.MYCORP_kerberos-backend-mit (109.84s)
        --- PASS: kuttl/harness/kerberos-s3_postgres-12.5.6_hive-4.0.1_krb5-1.21.1_openshift-false_s3-use-tls-false_kerberos-realm-PROD.MYCORP_kerberos-backend-mit (107.09s)
        --- PASS: kuttl/harness/kerberos-s3_postgres-12.5.6_hive-4.0.0_krb5-1.21.1_openshift-false_s3-use-tls-true_kerberos-realm-PROD.MYCORP_kerberos-backend-mit (132.82s)
        --- PASS: kuttl/harness/kerberos-s3_postgres-12.5.6_hive-4.0.0_krb5-1.21.1_openshift-false_s3-use-tls-false_kerberos-realm-PROD.MYCORP_kerberos-backend-mit (110.03s)
        --- PASS: kuttl/harness/kerberos-s3_postgres-12.5.6_hive-3.1.3_krb5-1.21.1_openshift-false_s3-use-tls-true_kerberos-realm-PROD.MYCORP_kerberos-backend-mit (119.68s)
        --- PASS: kuttl/harness/kerberos-s3_postgres-12.5.6_hive-3.1.3_krb5-1.21.1_openshift-false_s3-use-tls-false_kerberos-realm-PROD.MYCORP_kerberos-backend-mit (118.54s)
        --- PASS: kuttl/harness/upgrade_postgres-12.5.6_hive-old-3.1.3_hive-new-4.0.1_openshift-false (70.49s)
        --- PASS: kuttl/harness/cluster-operation_hive-latest-4.0.1_openshift-false (61.16s)
        --- PASS: kuttl/harness/logging_postgres-12.5.6_hive-4.0.0_openshift-false (79.92s)
        --- PASS: kuttl/harness/resources_hive-4.0.0_openshift-false (26.53s)
        --- PASS: kuttl/harness/resources_hive-3.1.3_openshift-false (26.19s)
        --- PASS: kuttl/harness/external-access_hive-latest-4.0.1_openshift-false (36.33s)
        --- PASS: kuttl/harness/orphaned-resources_hive-latest-4.0.1_openshift-false (37.07s)
        --- PASS: kuttl/harness/logging_postgres-12.5.6_hive-4.0.1_openshift-false (78.39s)
        --- PASS: kuttl/harness/smoke_postgres-12.5.6_hive-4.0.1_openshift-false_s3-use-tls-false (102.36s)
        --- PASS: kuttl/harness/logging_postgres-12.5.6_hive-3.1.3_openshift-false (87.95s)
        --- PASS: kuttl/harness/smoke_postgres-12.5.6_hive-4.0.1_openshift-false_s3-use-tls-true (96.98s)
        --- PASS: kuttl/harness/smoke_postgres-12.5.6_hive-4.0.0_openshift-false_s3-use-tls-false (102.11s)
        --- PASS: kuttl/harness/smoke_postgres-12.5.6_hive-4.0.0_openshift-false_s3-use-tls-true (100.83s)
        --- PASS: kuttl/harness/smoke_postgres-12.5.6_hive-3.1.3_openshift-false_s3-use-tls-true (103.19s)
PASS

Maleware · 2025-06-04T13:50:26Z

I might have run into stackabletech/hdfs-operator#686 during development.

I recognized that I can have an empty string in my discovery configMap from time to time. Behaviour appears to be flaky, but yet more often then not the emtpy string appears:

Expected

apiVersion: v1
data:
  HIVE: thrift://hive-postgres-s3-metastore-default.default.svc.cluster.local:9083
kind: ConfigMap
metadata:

Flaky faulty one

apiVersion: v1
data:
  HIVE: ""
kind: ConfigMap
metadata:

…tackabletech/hive-operator into feat/hive-listener-integration

Maleware · 2025-06-05T13:47:19Z

🟢

=== NAME  kuttl
    harness.go:403: run tests finished
    harness.go:510: cleaning up
    harness.go:567: removing temp folder: ""
--- PASS: kuttl (38.21s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/external-access_hive-latest-4.0.1_openshift-false (38.17s)
PASS

maltesander · 2025-06-10T11:57:11Z

rust/operator-binary/src/controller.rs

@@ -737,7 +770,7 @@ fn build_rolegroup_service(
    Ok(Service {
        metadata: ObjectMetaBuilder::new()
            .name_and_namespace(hive)
-            .name(rolegroup.object_name())
+            .name(format!("{name}-metrics", name = rolegroup.object_name()))


This is used multiple times, can we extract the name creation into a method?

maltesander · 2025-06-10T13:14:43Z

CHANGELOG.md

@@ -10,6 +10,7 @@ All notable changes to this project will be documented in this file.
  - Use `--file-log-max-files` (or `FILE_LOG_MAX_FILES`) to limit the number of log files kept.
  - Use `--file-log-rotation-period` (or `FILE_LOG_ROTATION_PERIOD`) to configure the frequency of rotation.
  - Use `--console-log-format` (or `CONSOLE_LOG_FORMAT`) to set the format to `plain` (default) or `json`.
+- BREAKING: Added listener support for Hive ([#605])


Suggested change

- BREAKING: Added listener support for Hive ([#605])

- BREAKING: Added Listener support for Hive ([#605])

maltesander · 2025-06-10T15:31:10Z

rust/operator-binary/src/controller.rs

@@ -1093,8 +1145,12 @@ fn build_metastore_rolegroup_statefulset(
                ),
                ..LabelSelector::default()
            },
-            service_name: Some(rolegroup_ref.object_name()),
+            service_name: Some(format!(
+                "{name}-metrics",


hint: use method here

maltesander · 2025-06-10T15:40:30Z

rust/operator-binary/src/discovery.rs

    NoServicePort {
        port_name: String,
-        obj_ref: ObjectRef<Service>,
+        //obj_ref: ObjectRef<Service>,


Remove or use the rolegroup provided in the build_listener_connection_string method.

maltesander · 2025-06-10T15:41:57Z

rust/operator-binary/src/discovery.rs

    kube::{Resource, runtime::reflector::ObjectRef},
 };

 use crate::{
    controller::build_recommended_labels,
-    crd::{HIVE_PORT, HIVE_PORT_NAME, HiveRole, ServiceType, v1alpha1},
+    crd::{HIVE_PORT_NAME, HiveRole, v1alpha1},
 };

 #[derive(Snafu, Debug)]


There are a couple of unused errors now, e.g. NoName or NoNamespace.

maltesander · 2025-06-10T15:47:47Z

tests/test-definition.yaml

@@ -105,6 +105,10 @@ tests:
    dimensions:
      - hive-latest
      - openshift
+  - name: external-access
+    dimensions:
+      - hive-latest


Should be tested for all versions?

maltesander · 2025-06-10T15:49:08Z

tests/templates/kuttl/external-access/install-hive.yaml.j2

+{% if lookup('env', 'VECTOR_AGGREGATOR') %}
+    vectorAggregatorConfigMapName: vector-aggregator-discovery
+{% endif %}


This one is not deployed see https://github.com/stackabletech/hive-operator/blob/main/tests/templates/kuttl/cluster-operation/00-install-vector-aggregator-discovery-configmap.yaml.j2

maltesander · 2025-06-10T15:49:41Z

tests/templates/kuttl/external-access/20-assert.yaml

+status:
+  readyReplicas: 2
+  replicas: 2
+


Suggested change

maltesander · 2025-06-10T15:51:30Z

rust/operator-binary/src/controller.rs


-    let role_svc_name = hive
-        .metastore_role_service_name()
-        .context(GlobalServiceNameNotFoundSnafu)?;


Error GlobalServiceNameNotFound not used anymore.

maltesander · 2025-06-10T16:44:29Z

rust/operator-binary/src/discovery.rs

    chroot: Option<&str>,
+    listener_refs: BTreeMap<&String, Listener>,


We should explicitly mention this in the release notes / breaking changes that the discovery key changed. Or we keep the HIVE key for backwards compatibility?
Trino wont work anymore etc.

Maleware added 8 commits May 27, 2025 14:55

WIP: Listener integration

d008047

Adding apiGroups for listeners

04558d9

Making clippy happy

4cf40c4

Working code

2af8e4a

Working test

42017f8

test definition

5ac30df

Cleaning up leftovers

de413d3

Fixing tests

e88fd8f

Adding Cargo.nix

ff8ebe0

Maleware marked this pull request as ready for review May 28, 2025 13:22

Cleaning up and renaming vars. First working example

8116051

lfrancke added this to Stackable Engineering Jun 4, 2025

lfrancke moved this to Development: In Progress in Stackable Engineering Jun 4, 2025

lfrancke assigned Maleware Jun 4, 2025

Maleware and others added 10 commits June 5, 2025 09:18

Making clippy happy

505471c

Merge branch 'main' into feat/hive-listener-integration

7074abf

remove unused input

0d1b223

Merge branch 'feat/hive-listener-integration' of https://github.com/s…

8781225

…tackabletech/hive-operator into feat/hive-listener-integration

Discovery configMap is filled properly

4b201a1

remove uneccessary files

19b0954

Refactor code, adding Cargo.lock and Cargo.nix

84e187e

Better comments

01a7329

Adding changelog

33e73b5

Adding docs

deb0ae7

Maleware changed the title ~~WIP: Listener integration~~ feat: Hive listener integration Jun 5, 2025

Making pre-commit happy

1e4ad32

Maleware moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Jun 5, 2025

Maleware requested a review from adwk67 June 5, 2025 13:56

maltesander self-requested a review June 10, 2025 11:22

maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 10, 2025

Merge branch 'main' into feat/hive-listener-integration

74aa8b4

maltesander requested changes Jun 10, 2025

View reviewed changes

maltesander reviewed Jun 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: Hive listener integration #605

feat: Hive listener integration #605

Uh oh!

Maleware commented May 27, 2025

Uh oh!

Maleware commented May 28, 2025

Uh oh!

Maleware commented Jun 4, 2025

Uh oh!

Maleware commented Jun 5, 2025

Uh oh!

maltesander Jun 10, 2025

Uh oh!

maltesander Jun 10, 2025

Uh oh!

maltesander Jun 10, 2025

Uh oh!

maltesander Jun 10, 2025

Uh oh!

maltesander Jun 10, 2025

Uh oh!

maltesander Jun 10, 2025

Uh oh!

maltesander Jun 10, 2025

Uh oh!

maltesander Jun 10, 2025

Uh oh!

maltesander Jun 10, 2025

Uh oh!

maltesander Jun 10, 2025

Uh oh!

Uh oh!

	- BREAKING: Added listener support for Hive ([#605])
	- BREAKING: Added Listener support for Hive ([#605])

		chroot: Option<&str>,
		listener_refs: BTreeMap<&String, Listener>,

Uh oh!

feat: Hive listener integration #605

Are you sure you want to change the base?

feat: Hive listener integration #605

Uh oh!

Conversation

Maleware commented May 27, 2025

Description

Definition of Done Checklist

Author

Reviewer

Acceptance

Uh oh!

Maleware commented May 28, 2025

Uh oh!

Maleware commented Jun 4, 2025

Expected

Flaky faulty one

Uh oh!

Maleware commented Jun 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!