Skip to content

Make segment cache configurable #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

Make segment cache configurable #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d49f222
Prepare unit test for segment cache configuration.
razvan Oct 17, 2022
23a1497
Update CHANGELOG and fix formatting errors.
razvan Oct 17, 2022
fa561bf
make regenerate-charts
razvan Oct 18, 2022
f78c04d
Merge branch 'main' into 306-make-segment-cache-size-configurable-and…
razvan Oct 18, 2022
2397669
Add explicit segment cache to historicals
razvan Oct 18, 2022
c530076
Fix formatting.
razvan Oct 18, 2022
ef989c8
Compute volume size for segment cache.
razvan Oct 18, 2022
82559b5
Merge branch 'main' into 306-make-segment-cache-size-configurable-and…
razvan Oct 18, 2022
a86685b
Update docs and default segment cache size.
razvan Oct 18, 2022
240f430
Replace DruidConfig with role based configuration structs.
razvan Oct 26, 2022
48a09b1
Merge branch 'main' into 306-make-segment-cache-size-configurable-and…
razvan Oct 26, 2022
6460538
Fixed format of volume quantity and add unit test for it.
razvan Oct 27, 2022
e8818aa
Extracted storage config for historical into separate struct.
razvan Oct 28, 2022
051b8fc
Merge branch 'main' into 306-make-segment-cache-size-configurable-and…
razvan Oct 29, 2022
d3d86c2
wip
razvan Oct 29, 2022
02661f8
wip: cleanup, fix try_merge added more unit tests
razvan Oct 30, 2022
0f85a63
Update product config, more unit tests.
razvan Oct 30, 2022
acea016
Cleanup, update docs and add SC_VOLUME_NAME
razvan Oct 30, 2022
90a773c
Bugfix: quantities only accept "G" or "Gi" but not "g".
razvan Nov 1, 2022
d1054c0
Update rust/crd/src/storage.rs
razvan Nov 1, 2022
cd5c545
Update rust/crd/src/storage.rs
razvan Nov 1, 2022
30d0dc9
Update rust/crd/src/resource.rs
razvan Nov 1, 2022
853132f
Fix TODOs according to the review feedback.
razvan Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ All notable changes to this project will be documented in this file.
- Cpu and memory limits are now configurable ([#298]).
- Stale resources are now deleted ([#310]).
- Support Druid 24.0.0 ([#317]).
- Added `segmentCacheSizeGb` to make segment cache (the max size of `druid.segmentCache.locations`) configurable ([#320])
- Refactor role configuration with per role structs like `BrokerConfig`, `HistoricalConfig`, etc ([#320])
- Added `HistoricalStorge` and `DruidStorage` (as catch-all storage configuration) ([#320])

### Changed

Expand All @@ -17,6 +20,7 @@ All notable changes to this project will be documented in this file.
[#298]: https://github.com/stackabletech/druid-operator/pull/298
[#310]: https://github.com/stackabletech/druid-operator/pull/310
[#317]: https://github.com/stackabletech/druid-operator/pull/317
[#320]: https://github.com/stackabletech/druid-operator/pull/320

## [0.7.0] - 2022-09-06

Expand Down
43 changes: 43 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion deploy/config-spec/properties.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@ properties:
type: "string"
defaultValues:
- fromVersion: "0.0.0"
value: "[{\"path\":\"/stackable/var/druid/segment-cache\",\"maxSize\":\"300g\"}]"
value: "[{\"path\":\"/stackable/var/druid/segment-cache\",\"maxSize\":\"900m\"}]"
roles:
- name: "broker"
required: false
Expand Down
20 changes: 20 additions & 0 deletions deploy/crd/druidcluster.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -298,6 +299,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -484,6 +486,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -630,6 +633,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -959,6 +963,12 @@ spec:
type: object
type: object
storage:
properties:
segmentCacheSizeGb:
format: uint16
minimum: 0.0
nullable: true
type: integer
type: object
type: object
type: object
Expand Down Expand Up @@ -1105,6 +1115,12 @@ spec:
type: object
type: object
storage:
properties:
segmentCacheSizeGb:
format: uint16
minimum: 0.0
nullable: true
type: integer
type: object
type: object
type: object
Expand Down Expand Up @@ -1422,6 +1438,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -1568,6 +1585,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -1765,6 +1783,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -1911,6 +1930,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down
2 changes: 1 addition & 1 deletion deploy/helm/druid-operator/configs/properties.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@ properties:
type: "string"
defaultValues:
- fromVersion: "0.0.0"
value: "[{\"path\":\"/stackable/var/druid/segment-cache\",\"maxSize\":\"300g\"}]"
value: "[{\"path\":\"/stackable/var/druid/segment-cache\",\"maxSize\":\"900m\"}]"
roles:
- name: "broker"
required: false
Expand Down
20 changes: 20 additions & 0 deletions deploy/helm/druid-operator/crds/crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -114,6 +115,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -207,6 +209,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -260,6 +263,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -496,6 +500,12 @@ spec:
type: object
type: object
storage:
properties:
segmentCacheSizeGb:
format: uint16
minimum: 0.0
nullable: true
type: integer
type: object
type: object
type: object
Expand Down Expand Up @@ -549,6 +559,12 @@ spec:
type: object
type: object
storage:
properties:
segmentCacheSizeGb:
format: uint16
minimum: 0.0
nullable: true
type: integer
type: object
type: object
type: object
Expand Down Expand Up @@ -773,6 +789,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -826,6 +843,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -930,6 +948,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -983,6 +1002,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down
2 changes: 1 addition & 1 deletion deploy/manifests/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ data:
type: "string"
defaultValues:
- fromVersion: "0.0.0"
value: "[{\"path\":\"/stackable/var/druid/segment-cache\",\"maxSize\":\"300g\"}]"
value: "[{\"path\":\"/stackable/var/druid/segment-cache\",\"maxSize\":\"900m\"}]"
roles:
- name: "broker"
required: false
Expand Down
20 changes: 20 additions & 0 deletions deploy/manifests/crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -115,6 +116,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -208,6 +210,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -261,6 +264,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -497,6 +501,12 @@ spec:
type: object
type: object
storage:
properties:
segmentCacheSizeGb:
format: uint16
minimum: 0.0
nullable: true
type: integer
type: object
type: object
type: object
Expand Down Expand Up @@ -550,6 +560,12 @@ spec:
type: object
type: object
storage:
properties:
segmentCacheSizeGb:
format: uint16
minimum: 0.0
nullable: true
type: integer
type: object
type: object
type: object
Expand Down Expand Up @@ -774,6 +790,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -827,6 +844,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -931,6 +949,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down Expand Up @@ -984,6 +1003,7 @@ spec:
type: object
type: object
storage:
description: Storage configuration used by all roles except historical
type: object
type: object
type: object
Expand Down
Loading