Skip to content

Docathon Tutorial Integration #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Apr 28, 2022
Merged

Docathon Tutorial Integration #181

merged 39 commits into from
Apr 28, 2022

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Apr 26, 2022

fixes #179

  • Merged all 3 files into one
  • General edits to harmonize the 3 files
  • new top-level navigation entry for tutorials
  • new module for tutorials
  • added tutorial to navigation

@fhennig fhennig marked this pull request as ready for review April 26, 2022 15:01
@fhennig fhennig requested a review from a team April 26, 2022 15:06
maltesander
maltesander reviewed Apr 26, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read it again and think we should be more consistent in some aspects:

  1. Switching between we and you
  2. Capitalization of Operator / Dependency
  3. (Non) Capitalization of Kubernetes keywords such as secret vs just a general secret
  4. Some words are written differently e.g. datasource vs data source
  5. Formal language should not use the abbreviations for we're, haven't etc.

Maybe im a stickler, but especially the we/you changes are annoying (at least for me)

Otherwise good work!

@fhennig
Copy link
Contributor Author

fhennig commented Apr 27, 2022

Hey, thanks! good points!

fhennig and others added 7 commits April 27, 2022 15:48
@fhennig @maltesander
Update modules/tutorials/pages/end-to-end_data_pipeline_example.adoc
466fcbf 
Co-authored-by: Malte Sander <[email protected]>
@fhennig @maltesander
Update modules/tutorials/pages/end-to-end_data_pipeline_example.adoc
9dbc68d 
Co-authored-by: Malte Sander <[email protected]>
@fhennig @maltesander
Update modules/tutorials/pages/end-to-end_data_pipeline_example.adoc
01e9024 
Co-authored-by: Malte Sander <[email protected]>
@fhennig @maltesander
Update modules/tutorials/pages/end-to-end_data_pipeline_example.adoc
9ba2959 
Co-authored-by: Malte Sander <[email protected]>
@fhennig @maltesander
Update modules/tutorials/pages/end-to-end_data_pipeline_example.adoc
99643ad 
Co-authored-by: Malte Sander <[email protected]>
@fhennig @maltesander
Update modules/tutorials/pages/end-to-end_data_pipeline_example.adoc
e03ba1f 
Co-authored-by: Malte Sander <[email protected]>
Adapted to Review
589e3ee
@fhennig fhennig requested a review from maltesander April 27, 2022 14:12
maltesander
maltesander reviewed Apr 27, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some more nits (sorry for not seeing that earlier).

fhennig and others added 6 commits April 28, 2022 09:07
@fhennig
Copy link
Contributor Author

fhennig commented Apr 28, 2022

Thanks, all good points! All merged in

maltesander
maltesander previously approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maltesander
maltesander approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhennig fhennig merged commit 4d4ad29 into main Apr 28, 2022
@fhennig fhennig deleted the docathon-integration branch April 28, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update documentation menu for docathon results
2 participants
@fhennig @maltesander