Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pr_test_build_images): Build changed products on PR #948

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Dec 5, 2024

Adds a workflow to test product images builds based on changed paths.

Some things to note:

  • Each product now has a versions.toml (see xxx)
  • Only product versions that are set to build_on_pr in their respective versions.toml file will be built and pushed.
    • Images will only be pushed to oci.stackable.tech.
  • Images will be generated with a -prXXX suffix, similar to what is done for the operators (eg: oci.stackable.tech/sdp/airflow:2.10.2-stackable0.0.0-dev-pr948)
  • This does not test dependent products (eg: a change in java-base will not trigger a build of druid).

Verified

This commit was signed with the committer’s verified signature.
@NickLarsenNZ NickLarsenNZ self-assigned this Dec 5, 2024
NickLarsenNZ and others added 11 commits December 5, 2024 15:08

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
It makes no sense, since this workflow is optimised for Pull Requests

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
Techassi Techassi
Techassi and others added 8 commits December 6, 2024 11:45

Verified

This commit was signed with the committer’s verified signature.
Techassi Techassi

Verified

This commit was signed with the committer’s verified signature.
… variable, and explain why we can't use the build output

Verified

This commit was signed with the committer’s verified signature.
…ges to avoid pointless builds

Verified

This commit was signed with the committer’s verified signature.
I have left a note in versions.py to remind people to update versions.toml and explain why there are now two files to maintain.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
…uct build workflows)

Verified

This commit was signed with the committer’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants