-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(nifi): Bump to 2.2.0 #167
Conversation
04ac1e8
to
700ce7b
Compare
700ce7b
to
afe10d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a full review. I was just curious.
demos/data-lakehouse-iceberg-trino-spark/create-nifi-ingestion-job.yaml
Outdated
Show resolved
Hide resolved
demos/data-lakehouse-iceberg-trino-spark/create-nifi-ingestion-job.yaml
Outdated
Show resolved
Hide resolved
…-job.yaml Co-authored-by: Razvan-Daniel Mihai <[email protected]>
…mp/nifi-2.2.0-git-registry-client
77c4ca0
to
58333ac
Compare
…mp/nifi-2.2.0-git-registry-client
5f0761f
to
88031ce
Compare
This is ready for review now. A few things won't work in the demos, but this is related to MinIO TLS and the Waterlevel demo has a bug in the Superset The current state of the code is laid out to pull the NiFi flows from the |
…mp/nifi-2.2.0-git-registry-client
8739374
to
fb79411
Compare
How about using "main" instead if "release-25.3" ? This would at least align the flows with the rest of the manifest paths, that we always update in the release branches anyway? |
Yeah, I changed it to "main" now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, thanks!
Part of stackabletech/nifi-operator#740
Summary of changes:
GitHubFlowRegistryClient
in NiFi 2.GitHubFlowRegistryClient
in NiFi and restore the flows of the specific demoPublishKafka_2_6
byPublishKafka
, becausePublishKafka_2_6
was removed. I did this by exporting the flow definition from NiFi 1, importing them into NiFi 2 and then manually replacing all processors with their NiFi 2 versions (and reconfiguring them if needed).The branch from which the flows are restored is hardcoded, which is not ideal, but I have no good idea yet on how to make this dynamic. It must be changed if something in the .json dumps of the process groups is changed, which should rarely happen, so it's likely not a huge problem.