Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Remote URLs in NiFi for fetching data #115

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Oct 23, 2024

Fix for #62
Also includes an updated screenshot for the documentation, which was showing errors in NiFi because of this.

NickLarsenNZ

This comment was marked as outdated.

@sbernauer
Copy link
Member

IMHO it's better to merge into main to get the fix right now. There is no need to wait for SDP 24.11, as we are not using any new product versions or features of it

@NickLarsenNZ NickLarsenNZ self-requested a review October 24, 2024 09:46
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ
Copy link
Member

IMHO it's better to merge into main to get the fix right now. There is no need to wait for SDP 24.11, as we are not using any new product versions or features of it

I'll update the next branch once this is merged.

@xeniape xeniape added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 8841a8d Oct 24, 2024
2 checks passed
@xeniape xeniape deleted the fix/update-lakehouse-demo-api-endpoints branch October 24, 2024 09:59
@sbernauer
Copy link
Member

I'll update the next branch once this is merged.

I though we are going to merge next into main eventually? Wouldn't this cause merge conflicts?

@sbernauer
Copy link
Member

Ahh or merge main into next? That would make sense I guess

@NickLarsenNZ
Copy link
Member

I'll cherry-pick this into the release-24.7 branch.

NickLarsenNZ pushed a commit that referenced this pull request Nov 13, 2024
* fix: Update Remote URLs in NiFi for fetching data

* docs: update nifi screenshot to one without errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants