Skip to content

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Dec 23, 2025

Description

Tests 🟢 https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/68/

Airflow code sets the default value of API_WORKERS to 4: this did not present any problems for Airflow 2.x, but was problematic in 3.x until 3.0.6, which included the version of uvicorn that honoured the timeout value that Airflow sends through.

The default of 4 is/was fine for our integration tests as the default resources have also been increased, but

  • the docs were inconsistent between stating the default (4) and the recommendation (single worker)
  • some users still report issues in their environments with webserver child processes being killed

This PR addresses both of the above by setting the default back to 1 and ensuring the docs are now consistent.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 marked this pull request as ready for review December 23, 2025 11:53
@adwk67 adwk67 self-assigned this Dec 23, 2025
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Dec 23, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this change!

I personally would even argue this is a fix:

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Dec 23, 2025
adwk67 and others added 4 commits December 23, 2025 16:08
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

3 participants