Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate collision specific features in pinocchio_default #2517

Merged

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Dec 18, 2024

Add PINOCCHIO_WITH_HPP_FCL definiton on pinocchio_default target (when build with collision support) to build with core algorithms with collision support.

Draw back is if an user build pinocchio from sources with collision support but then want to build against pinocchio_default target without hpp-fcl/coal.

Bonus:

  • Fix linux.yml CI
  • Remove hpp-fcl from pkg-config file since hpp-fcl doesn't provide a .pc file

jcarpent
jcarpent previously approved these changes Dec 19, 2024
@jorisv jorisv force-pushed the topic/collision_in_core_quickfix branch from 6a49257 to 8a4a51d Compare December 19, 2024 16:17
@jorisv jorisv requested a review from jcarpent December 20, 2024 08:40
@jcarpent jcarpent merged commit 0d820be into stack-of-tasks:devel Dec 20, 2024
23 checks passed
@jorisv jorisv deleted the topic/collision_in_core_quickfix branch December 20, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants