Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprechiated pinocchio 3 branch link in Readme #2457

Closed

Conversation

manumerous
Copy link

Hi, when checking out Pinocchio after a while I was confused about the statement that Pinocchio3 is only available in the preview branch with a dead link. So I thought it would be nice to quickly adapt this to make it clear for others.

@hrp2-14
Copy link

hrp2-14 commented Oct 14, 2024

Hi ! This project doesn't usually accept pull requests on the main branch.
If this wasn't intentionnal, you can change the base branch of this PR to devel
(No need to close it for that). Best, a bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

nim65s
nim65s previously approved these changes Oct 14, 2024
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@nim65s nim65s changed the base branch from master to devel October 14, 2024 17:15
@nim65s nim65s dismissed their stale review October 14, 2024 17:15

The base branch was changed.

@nim65s nim65s self-requested a review October 14, 2024 17:15
@jcarpent jcarpent enabled auto-merge October 14, 2024 18:41
@jcarpent jcarpent disabled auto-merge October 14, 2024 18:41
Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manumerous Thanks a lot for the nice update.
In fact, I've just realised that is already in the readme of the devel branch. See https://github.com/stack-of-tasks/pinocchio/tree/devel?tab=readme-ov-file#introducing-pinocchio-3.

I guess we can now close this PR.
We will proceed soon to a new release of Pinocchio.

@manumerous manumerous closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants