-
Notifications
You must be signed in to change notification settings - Fork 56
test: add ignore() context manager test coverage #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jsignell
merged 8 commits into
stac-utils:main
from
nlebovits:lebovits/590-increase-test-coverage
Oct 9, 2025
+58
−7
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b8ae336
test: add ignore() context manager test coverage
nlebovits 6f443ba
Merge branch 'main' into lebovits/590-increase-test-coverage
nlebovits 99b4996
test: add ignore() context manager test coverage
nlebovits 58d619a
Revert test_client.py to main branch state
nlebovits 5221373
Add pytest warning filters for CI stability
nlebovits 99bb6ca
Add changelog entry for warning context manager test coverage
nlebovits 1c01b9c
Merge branch 'main' into lebovits/590-increase-test-coverage
nlebovits bd83e0d
Merge branch 'main' into lebovits/590-increase-test-coverage
jsignell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
import pytest | ||
|
||
from pystac_client import Client | ||
from pystac_client.warnings import DoesNotConformTo, ignore, strict | ||
|
||
from .helpers import TEST_DATA | ||
|
||
|
||
class TestWarningContextManagers: | ||
@pytest.mark.filterwarnings("error") | ||
jsignell marked this conversation as resolved.
Show resolved
Hide resolved
|
||
def test_ignore_context_manager(self) -> None: | ||
"""Test that ignore() context manager suppresses warnings.""" | ||
api = Client.from_file(str(TEST_DATA / "planetary-computer-root.json")) | ||
api.remove_conforms_to("COLLECTION_SEARCH") | ||
|
||
with ignore(): | ||
api.collection_search(limit=10, max_collections=10, q="test") | ||
|
||
@pytest.mark.filterwarnings("error") | ||
def test_strict_context_manager(self) -> None: | ||
"""Test that strict() context manager converts warnings to exceptions.""" | ||
api = Client.from_file(str(TEST_DATA / "planetary-computer-root.json")) | ||
api.remove_conforms_to("COLLECTION_SEARCH") | ||
|
||
with strict(): | ||
with pytest.raises(DoesNotConformTo, match="COLLECTION_SEARCH"): | ||
api.collection_search(limit=10, max_collections=10, q="test") | ||
|
||
def test_ignore_context_manager_cleanup(self) -> None: | ||
"""Test that ignore() properly restores warning filters after exit.""" | ||
api = Client.from_file(str(TEST_DATA / "planetary-computer-root.json")) | ||
api.remove_conforms_to("COLLECTION_SEARCH") | ||
|
||
with ignore(): | ||
api.collection_search(limit=10, max_collections=10, q="test") | ||
|
||
with strict(): | ||
with pytest.raises(DoesNotConformTo, match="COLLECTION_SEARCH"): | ||
api.collection_search(limit=10, max_collections=10, q="test") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.