feat(users): verify mention targets directly - #132
Open
dwaxe wants to merge 1 commit into
Open
Conversation
dwaxe
force-pushed
the
dwaxe/strict-user-resolution-129
branch
from
August 5, 2026 08:50
e0e89dc to
11608d5
Compare
dwaxe
force-pushed
the
dwaxe/strict-user-resolution-129
branch
from
August 5, 2026 12:00
11608d5 to
50604e0
Compare
Slack IDs were accepted without checking whether they identify an active human. Add user resolve for IDs and emails. It uses direct Slack lookups and emits mentions only when the whole batch passes. Names and handles are rejected; no directory scan is used.
dwaxe
force-pushed
the
dwaxe/strict-user-resolution-129
branch
from
August 5, 2026 12:25
50604e0 to
3d5188a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the ID and email cases in #129.
Problem
A valid-looking Slack ID may not identify an active human. Resolving targets one at a time can also produce a partial mention batch.
Fix
Add
agent-slack user resolvefor canonical IDs and emails. It uses direct Slack lookups and emits mentions only when every target is an active human.Names and handles are rejected. The command never scans the user directory.