fix(search): stop omitting older channel results - #130
Open
dwaxe wants to merge 1 commit into
Open
Conversation
Channel-scoped search reads only the newest conversations.history page, so older matches are omitted. Reaching the result limit can also resolve users when that was not requested. Continue through older pages until history ends, the requested time boundary is reached, or enough results are found. Use the shared result formatter so user resolution remains opt-in.
dwaxe
force-pushed
the
dwaxe/fix-channel-search-pagination
branch
from
August 5, 2026 08:50
78c9d5b to
436fdbc
Compare
dwaxe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Channel-scoped search reads only the first
conversations.historypage, so it misses older messages. Its result-limit path can also resolve users without the caller requesting it.Fix
Continue through older history pages until Slack reports no more messages, the
--afterboundary is reached, or the result limit is met. Return results through the shared formatter so user resolution remains opt-in.