fix(auth): prevent credentials from reaching untrusted origins - #128
Open
dwaxe wants to merge 1 commit into
Open
fix(auth): prevent credentials from reaching untrusted origins#128dwaxe wants to merge 1 commit into
dwaxe wants to merge 1 commit into
Conversation
dwaxe
force-pushed
the
dwaxe/validate-slack-workspace-origins
branch
from
August 5, 2026 08:50
be8d072 to
9f157bb
Compare
dwaxe
changed the title
Browser auth sends a token and cookie to the configured workspace URL. Accept only Slack and GovSlack HTTPS URLs, recheck them before requests, reject redirects, and store cookies per workspace.
dwaxe
force-pushed
the
dwaxe/validate-slack-workspace-origins
branch
from
August 5, 2026 12:00
9f157bb to
e9897b8
Compare
dwaxe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Browser auth sends a token and cookie to the configured workspace URL. An arbitrary URL can receive them. The old shared cookie also cannot be safely reused between commercial Slack and GovSlack.
Fix
slack.comorslack-gov.com.Users relying on the old shared Keychain cookie must re-import browser or Desktop auth once. Automatic GovSlack browser/Desktop import and GovSlack permalink parsing are not included.