Open
Conversation
…check in LoadChainConfigWithOverride
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the WBFT consensus engine is initialized using a stale ChainConfig loaded from the database before chain config overrides are applied.
As a result, hardfork settings defined in the genesis or via code-level overrides were not reflected in the consensus engine at initialization time, causing a mismatch between the blockchain and the engine configuration.
This change ensures that the consensus engine is always created using the final ChainConfig with overrides applied.
Background
In the standard Ethereum initialization flow, the final ChainConfig is resolved inside NewBlockChain via SetupGenesisBlockWithOverride.
However, in the current go-stablenet flow:
This leads to the consensus engine and the blockchain using different ChainConfig values.
Problem
SetupGenesisBlockWithOverrideImpact
Solution
Key idea
Use a lightweight helper that resolves the final ChainConfig with overrides applied without committing the genesis block, and use it to initialize the consensus engine.
Changes