fix: normalize comma-separated config strings#56
Merged
hominlee-wemade merged 2 commits intodevfrom Feb 11, 2026
Merged
Conversation
Use split + TrimSpace per item and drop empty entries for all comma-separated config used in system contract init (members, validators, blsPublicKeys, blacklist, authorizedAccounts, minters, minterAllowed, etc.) instead of using the raw strings. Ensures consistent hashAlloc/root for the same config.
egonspace
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
System contract initialization now parses comma-separated config strings (members, validators, blsPublicKeys, blacklist, authorizedAccounts, minters, minterAllowed, etc.) in a normalized way:
This ensures that genesis alloc (and therefore
hashAlloc/ state root) is consistent for the same logical configuration, regardless of formatting differences such as"a, b"vs"a,b".Background
hashAlloc.(address, account)set, the trie yields the same root regardless of insertion order.hashAllocactually differs.Changes
splitAndTrim(s, sep string) []stringutility (split bysep, trim each element, omit empty entries)memberAddressesfrommembersStrmemberAddresses,valAddresses, andblsKeyStringsusingsplitAndTrim(..., ",")blacklistAddressesandauthorizedAccountAddressesusingsplitAndTrim(..., ",")mintersandminterAllowedusingsplitAndTrim(..., ",")minterAddressStrsfrommintersStrusingsplitAndTrim(..., ",")