feat: enforce minimum gas fee floor when Anzeon is enabled#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Anzeon is enabled and the chain is past the London fork, this PR enforces a minimum gas fee floor (minBaseFee + gasTip) during txpool validation.
The same rule applies not only to DynamicFeeTx but also to Legacy and AccessList transactions, by using
GasFeeCap()(which equalsgasPricefor legacy-style txs).Changes
IsLondon(head.Number) && AnzeonEnabled()minFee = MinBaseFee + GasTipErrUnderpricedwhentx.GasFeeCap() < minFeeTestMinimumGasFeeValidationErrUnderpriced)Why
Testing
core/txpool/legacypool/legacypool_test.goNotes
GasFeeCap()returnsgasPrice, so this validation effectively means:legacy gasPrice >= MinBaseFee + GasTip