Skip to content

refactor: reorganize cabal.project files #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: stable-ghc-9.14-rebased
Choose a base branch
from
Open

refactor: reorganize cabal.project files #100

wants to merge 2 commits into from

Conversation

@andreabedini
Copy link
Member

@andreabedini andreabedini commented Oct 7, 2025

  • Improve the consistency across the stage cabal.project files by using the same ordering and delimiter comments
  • "package-dbs: clear, global" is the default so it's removed

@andreabedini andreabedini requested a review from angerman October 7, 2025 07:03
@andreabedini andreabedini force-pushed the wip/andrea/tidy-project-files branch from 80b595e to f24a080 Compare October 7, 2025 07:13
@angerman
Copy link

angerman commented Oct 8, 2025

I think @hasufell should have a look at this as well. And as with #99, I think this should also be against #89, as it's basically a refinement of that PR.

angerman
angerman approved these changes Oct 8, 2025
View reviewed changes
Copy link

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement. I'm a bit concerned it might mess with #75?

@hasufell
Copy link
Member

hasufell commented Oct 20, 2025

Yes... this is a refactoring and not a feature, so it should be lower in priority than any existing feature PR.

@andreabedini andreabedini force-pushed the wip/andrea/tidy-project-files branch 3 times, most recently from 1bf97e3 to f45f550 Compare November 12, 2025 03:49
@andreabedini
fix handling of index-state
abe6585
@andreabedini
refactor: reorganize cabal.project files
0db26b1 
- Improve the consistency across the stage cabal.project files by using the same ordering and delimiter comments
- "package-dbs: clear, global" is the default so it's removed
@andreabedini andreabedini force-pushed the wip/andrea/tidy-project-files branch from f45f550 to 0db26b1 Compare November 14, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angerman angerman angerman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andreabedini @angerman @hasufell