Dual compiler support #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't enable -threaded unconditionnally when building Setup.hs. We may only have vanilla libraries (but maybe we don't have them either?) Revert ae0e752
The treatment of --executable-static means we pass `-optl-static` to GHC, which in turn just passes this to the linker. This flag can not work on macOS. Fully static linking is impossible as libSystem must be linked dynamically. Thus here we disable this flag for macOS.
This reverts b408167 in spirit from haskell#4656.
Run a program (named "preBuildHook") before doing a package build and another program (named "postBuildHook") after the package is built. The exit code from the pre-build hook is passed to the post-build hook. The commit includes documentation for the hooks and the security safeguards implemented to avoid the running of malicious hook files. (cherry picked from commit 5f7b47f)
This has to be cleaned up but it does not make sense to pass the compiler.
Remove QualifyOptions by setting qoSetupIndependent to be always true (the current default) and qoBaseShim false (this must have been just a hack of some sort).
principalPP and setupPP seem to have gone unused since 8194fab
I would need to rework packagesWithLibDepsDownwardClosedProperty. It has to be done but not now.
This reverts commit f860065.
This reverts commit 1259214.
(cherry picked from commit 79b31e1)
(cherry picked from commit f860065)
(cherry picked from commit 1259214)
If we try to parse <flavour>-<version>-<pkg>-<version> for e.g. <pkg>-<version> this will break in -- | Parse the @setup-config@ file header, returning the package identifiers -- for Cabal and the compiler. parseHeader :: ByteString -- ^ The file contents. -> IO (PackageIdentifier, PackageIdentifier) The issue is that we I guess parse e.g. Cabal-x.y.z as compiler flavour + version, and then have nothing for the PackageIdentifier to parse. This code needs to be fixed properly to try and parse compier-version-pkg-version or only pkg-version (and set compiler to Nothing).
This reverts commit 5b81693.
This reverts commit c520482.
This patch is quite raw. - Effectively ComponentId and UnitId are very similar. I think UnitId should just be a newtype around ComponentId. - We have Partial IDs, which should really be called Legacy, as they deal with non-compiler-prefixed ids. - We need to modify the parsing of installed packages, to inject the compiler into unit-ids. - We also need to modify parsing configure flags (--dependency=...) to ensure the ids are aligned. Note: we need to support INTERNAL and EXTERNAL Setup.hs. (This shows up with --dependency=...) especially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.