Support for doctrine/dbal v4 #754
Conversation
|
CI seems no longer running properly with your changes. jobs no longer start |
|
Yeah, but I wasn't sure why exactly 😅 do you have any idea? I'll try to back to this in couple of days 😉 |
.github/workflows/tests.yml
Outdated
| @@ -120,7 +144,7 @@ jobs: | |||
| run: composer require sqlftw/sqlftw --ignore-platform-req=php+ | |||
|
|
|||
| - name: Install doctrine/dbal (optional dependency) | |||
| run: composer require doctrine/dbal:^3 --ignore-platform-req=php+ | |||
| run: composer require doctrine/dbal:${{ matrix.dbal-version }} --ignore-platform-req=php+ | |||
There was a problem hiding this comment.
I guess this command now needs to be wrapped into double quotes
bnowak
force-pushed
the
add-support-for-dbal-v4
branch
from
51deb2d to
f74b52f
Compare
staabm
force-pushed
the
add-support-for-dbal-v4
branch
from
f74b52f to
9a432ae
Compare
bnowak
force-pushed
the
add-support-for-dbal-v4
branch
from
9a432ae to
f3f862b
Compare
…atement methods to validate queries syntax errors
|
@staabm I guess now the PR is in state that would be ready for review, however there're still some jobs blocked and not triggered. I'm not sure what is the cause they don't want to start. I tried wrapping in double quotes of require dbal lib in both ways: - name: Install doctrine/dbal (optional dependency)
run: "composer require doctrine/dbal:${{ matrix.dbal-version }} --ignore-platform-req=php+"
...
run: composer require "doctrine/dbal:${{ matrix.dbal-version }}" --ignore-platform-req=php+but there's the same result. I'm not sure that's related 😞 🤔 Do you have any other idea? |
| @@ -79,13 +79,13 @@ public function syntaxErrorPdoPrepare(PDO $pdo) | |||
| public function syntaxErrorDoctrineDbal(\Doctrine\DBAL\Connection $conn) | |||
| { | |||
| $sql = 'SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada'; | |||
| $conn->query($sql); | |||
| $conn->executeQuery($sql); | |||
There was a problem hiding this comment.
said differently: we also need the previous test with ->query() but just run it on 3.x
There was a problem hiding this comment.
Connection::query method was deprecated in DBAL 3 and was deleted in DBAL 4.
Target solution is to use executeQuery in both, so I adjusted test to be valid for both versions.
Also, I added Connection::executeQuery and Connection::executeStatement in injected methods to validate in SyntaxErrorInQueryMethodRule class - IMO they should be there from the very beginning as well.
There was a problem hiding this comment.
If you want to keep that test-case, I'd need to create separate test data file and include it conditionally only for dbal3 (simillary as with doctrine-dbal3.php file). It's because of the Connection::query method is missing in dbal4 and it wouldn't be parsed by phpstan (it would skip analyzing query syntax, so expected test error wouldn't be thrown)
Will that be fine?
There was a problem hiding this comment.
to be precise: just copy the previous code into a new file and make it beeing analyzed by the corresponding rule-test.
we only need the 3.x only-api tested in the new file
|
thank you! |
|
Thanks as well :) any chances that could be released soon? |
No description provided.