runners: refactoring to simplify & future-proof#2136
Merged
Conversation
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
iurii-ssv
commented
Apr 9, 2025
80a7a2b to
817baf1
Compare
iurii-ssv
commented
Apr 9, 2025
nkryuchkov
previously approved these changes
Apr 10, 2025
iurii-ssv
commented
May 5, 2025
553e27b to
9742eee
Compare
Contributor
Author
|
Force-pushing to make sure every commit in this PR is gpg-signed (otherwise we cannot merge it) |
a967ca4 to
2b38c91
Compare
2b38c91 to
5da6287
Compare
julienh-ssv
requested changes
Sep 11, 2025
julienh-ssv
previously approved these changes
Sep 16, 2025
Contributor
oleg-ssvlabs
left a comment
There was a problem hiding this comment.
good stuff. I left few questions
oleg-ssvlabs
previously approved these changes
Sep 17, 2025
julienh-ssv
previously approved these changes
Sep 18, 2025
y0sher
reviewed
Sep 18, 2025
y0sher
reviewed
Sep 18, 2025
y0sher
reviewed
Sep 18, 2025
y0sher
reviewed
Sep 18, 2025
a51e101
y0sher
approved these changes
Sep 22, 2025
Contributor
y0sher
left a comment
There was a problem hiding this comment.
Great job, code looks much cleaner and a lot of tech debt was resolved 🔥
oleg-ssvlabs
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors a bunch of code around Runner(s) (and
BaseRunnerin particular):It is a subset of functionality I've implemented while working on pre-confirmations (initial draft) - I'm pulling this refactoring out into separate PR here because:
Also closes #2311
Before merging: