Skip to content

runners: refactoring to simplify & future-proof#2136

Merged
iurii-ssv merged 24 commits into
stagefrom
runners-refactoring
Sep 22, 2025
Merged

runners: refactoring to simplify & future-proof#2136
iurii-ssv merged 24 commits into
stagefrom
runners-refactoring

Conversation

@iurii-ssv
Copy link
Copy Markdown
Contributor

@iurii-ssv iurii-ssv commented Apr 9, 2025

This PR refactors a bunch of code around Runner(s) (and BaseRunner in particular):

  • rearranges some code to make runners a bit more flexible (eg. so we can implement a Runner that can execute a bunch of things in parallel)
  • simplifies & clarifies some things

It is a subset of functionality I've implemented while working on pre-confirmations (initial draft) - I'm pulling this refactoring out into separate PR here because:

Also closes #2311

Before merging:

  • resolve TODOs
  • test on stage

@iurii-ssv iurii-ssv marked this pull request as draft April 9, 2025 12:21
@iurii-ssv iurii-ssv changed the title runners: refactoring to simplify runners: refactoring to simplify & future-proof Apr 9, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2025

Codecov Report

❌ Patch coverage is 71.05263% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.3%. Comparing base (164e25c) to head (d185aba).
⚠️ Report is 1 commits behind head on stage.

Files with missing lines Patch % Lines
operator/validator/controller.go 68.7% 10 Missing ⚠️
operator/validator/task_executor.go 83.3% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread scripts/differ/parser.go
@iurii-ssv iurii-ssv force-pushed the runners-refactoring branch from 80a7a2b to 817baf1 Compare April 9, 2025 14:34
Comment thread scripts/spec-alignment/differ.config.yaml Outdated
@iurii-ssv iurii-ssv marked this pull request as ready for review April 9, 2025 14:41
nkryuchkov
nkryuchkov previously approved these changes Apr 10, 2025
Comment thread protocol/v2/ssv/validator/startup.go Outdated
@iurii-ssv iurii-ssv force-pushed the runners-refactoring branch from 553e27b to 9742eee Compare June 11, 2025 15:07
@iurii-ssv
Copy link
Copy Markdown
Contributor Author

Force-pushing to make sure every commit in this PR is gpg-signed (otherwise we cannot merge it)

@iurii-ssv iurii-ssv force-pushed the runners-refactoring branch from 2b38c91 to 5da6287 Compare August 25, 2025 10:06
@iurii-ssv iurii-ssv requested a review from nkryuchkov September 9, 2025 12:31
Comment thread protocol/v2/ssv/validator/startup.go Outdated
Comment thread protocol/v2/ssv/validator/timer.go
Comment thread protocol/v2/ssv/validator/validator.go Outdated
julienh-ssv
julienh-ssv previously approved these changes Sep 16, 2025
Copy link
Copy Markdown
Contributor

@oleg-ssvlabs oleg-ssvlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff. I left few questions

Comment thread operator/validator/controller.go Outdated
Comment thread protocol/v2/ssv/runner/runner.go Outdated
Comment thread protocol/v2/ssv/runner/runner.go Outdated
Comment thread protocol/v2/ssv/validator/startup.go
oleg-ssvlabs
oleg-ssvlabs previously approved these changes Sep 17, 2025
julienh-ssv
julienh-ssv previously approved these changes Sep 18, 2025
Comment thread eth/eventhandler/event_handler.go Outdated
Comment thread operator/validator/controller.go
Comment thread protocol/v2/ssv/validator/committee_queue.go
Comment thread scripts/spec-alignment/differ.config.yaml
@iurii-ssv iurii-ssv dismissed stale reviews from julienh-ssv and oleg-ssvlabs via a51e101 September 18, 2025 16:21
Copy link
Copy Markdown
Contributor

@y0sher y0sher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, code looks much cleaner and a lot of tech debt was resolved 🔥

@iurii-ssv iurii-ssv merged commit a6898a6 into stage Sep 22, 2025
8 checks passed
@iurii-ssv iurii-ssv deleted the runners-refactoring branch September 22, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants