fix: use valid BLS bytes in proposer fixtures#628
Closed
diegomrsantos wants to merge 3 commits into
Closed
Conversation
Author
|
Closing this as superseded by Shane's #627, which fixes the raw proposer fixture literals directly and includes the regen tooling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #622 by normalizing the Capella and Deneb proposer fixtures to use BLS pubkey and signature bytes that Herumi accepts as compressed values.
The raw beacon_node_consts.go JSON constants are intentionally unchanged in the final PR diff. They are huge minified literals, so the fix now happens after decoding the fixtures into typed proposer objects. This keeps the reviewable code small while still producing regenerated proposer and randao vectors with valid BLS bytes.
Notes for reviewers
Start with types/testingutils/beacon_node_proposer.go and types/testingutils/beacon_node_consts_test.go. The JSON files are generated output from the changed proposer fixture roots.
I intentionally excluded unrelated generator drift from current upstream/main:
Verification
Passed: types package tests, fixture generation with goimports on PATH, and proposer-only SSV spectests.
The full SSV spectest still hits the existing unrelated aggregator-committee fixture mismatch when the unrelated generator drift is kept out of this PR.