Skip to content

fix: use valid BLS bytes in proposer fixtures#628

Closed
diegomrsantos wants to merge 3 commits into
ssvlabs:mainfrom
diegomrsantos:fix/proposer-valid-bls-fixtures-scoped
Closed

fix: use valid BLS bytes in proposer fixtures#628
diegomrsantos wants to merge 3 commits into
ssvlabs:mainfrom
diegomrsantos:fix/proposer-valid-bls-fixtures-scoped

Conversation

@diegomrsantos
Copy link
Copy Markdown

@diegomrsantos diegomrsantos commented May 6, 2026

Summary

Fixes #622 by normalizing the Capella and Deneb proposer fixtures to use BLS pubkey and signature bytes that Herumi accepts as compressed values.

The raw beacon_node_consts.go JSON constants are intentionally unchanged in the final PR diff. They are huge minified literals, so the fix now happens after decoding the fixtures into typed proposer objects. This keeps the reviewable code small while still producing regenerated proposer and randao vectors with valid BLS bytes.

Notes for reviewers

Start with types/testingutils/beacon_node_proposer.go and types/testingutils/beacon_node_consts_test.go. The JSON files are generated output from the changed proposer fixture roots.

I intentionally excluded unrelated generator drift from current upstream/main:

  • three aggregator committee JSON files
  • six generated SSZ encoding hash files
  • eight signed SSV message / SSV message JSON files

Verification

Passed: types package tests, fixture generation with goimports on PATH, and proposer-only SSV spectests.

The full SSV spectest still hits the existing unrelated aggregator-committee fixture mismatch when the unrelated generator drift is kept out of this PR.

@diegomrsantos
Copy link
Copy Markdown
Author

Closing this as superseded by Shane's #627, which fixes the raw proposer fixture literals directly and includes the regen tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capella/Deneb proposer fixtures reuse codec-only BLS placeholder bytes and fail strict decoders

1 participant