Skip to content

chore(ci) - Update actions base image to node:24#613

Open
vaclav-ssvlabs wants to merge 2 commits into
mainfrom
chore/ci-node24-actions
Open

chore(ci) - Update actions base image to node:24#613
vaclav-ssvlabs wants to merge 2 commits into
mainfrom
chore/ci-node24-actions

Conversation

@vaclav-ssvlabs
Copy link
Copy Markdown

Summary

GitHub is enforcing Node.js 24 for GitHub Actions runtime and will block workflows that rely on older Node runtimes.

This PR updates CI workflows to align with the requirement.

Changes

  • Update reusable action references (uses:) to latest released versions.
  • Update workflow Node container images (node:<version>) to node:24 where they were below 24.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 26, 2026

Greptile Summary

This PR updates actions/setup-go from @v5 to @v6.3.0 in both CI workflows (lint.yaml and test.yaml). The v6 major version upgrades the action's internal Node.js runtime from node20 to node24, addressing GitHub's upcoming enforcement of Node.js 24 for Actions runtimes (effective June 2, 2026).

Key changes:

  • actions/setup-go@v5actions/setup-go@v6.3.0 in .github/workflows/lint.yaml
  • actions/setup-go@v5actions/setup-go@v6.3.0 in .github/workflows/test.yaml

One potential gap:

  • actions/checkout@v4 is left unchanged in both files. The officially node24-upgraded checkout action is Checkout v5 (@v4 still uses node20). For complete compliance ahead of the June 2026 enforcement, actions/checkout@v5 should be used as well.

Confidence Score: 4/5

Safe to merge; the core setup-go update is correct and the only gap is a missing checkout@v5 upgrade for full node24 compliance.

The actions/setup-go@v6.3.0 update is the right call — v6.3.0 is the latest release and correctly upgrades the node runtime to node24. The change is minimal and low-risk. The one outstanding item is that actions/checkout@v4 (node20) was not updated to @v5 (node24), leaving the checkout step on the older runtime until June 2026 enforcement. This is non-blocking.

Both .github/workflows/lint.yaml and .github/workflows/test.yaml share the same actions/checkout@v4 concern.

Important Files Changed

Filename Overview
.github/workflows/lint.yaml Updates actions/setup-go from @v5 to @v6.3.0 (node24 runtime); actions/checkout remains at @v4 which uses node20, potentially leaving an incomplete node24 migration.
.github/workflows/test.yaml Updates actions/setup-go from @v5 to @v6.3.0 (node24 runtime); same incomplete actions/checkout@v4 concern as lint.yaml.

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Runner
    participant CO as actions/checkout@v4<br/>(node20)
    participant SG as actions/setup-go@v6.3.0<br/>(node24)
    participant Steps as Subsequent Steps

    GH->>CO: Checkout repository (node20 runtime)
    CO-->>GH: Source code ready
    GH->>SG: Set up Go 1.22.x (node24 runtime)
    SG-->>GH: Go environment configured
    GH->>Steps: Run lint / test commands
    Steps-->>GH: Results

    note over CO: Still on node20 — not yet updated to v5
    note over SG: Updated in this PR from v5 → v6.3.0 (node24)
Loading

Reviews (1): Last reviewed commit: "chore(ci) - Update actions base image to..." | Re-trigger Greptile

Comment thread .github/workflows/lint.yaml Outdated
Copy link
Copy Markdown
Contributor

@iurii-ssv iurii-ssv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we'd need to upgrade Golang to >= 1.25.0 in order to resolve the failing pipeline due to:

  • upstream actions/setup-go maintainers introduced the GOTOOLCHAIN=local behavior in v6 which prevents the pipeline from automatically auto-switching to Go 1.25+
  • this PR switched from actions/setup-go@v5 to actions/setup-go@v6, which is what activated that behavior in this pipeline

@GalRogozinski
Copy link
Copy Markdown
Contributor

@vaclav-ssvlabs
I think you did those changes in #610 as well?

Also maybe we should mind @iurii-ssv comment before merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants