Skip to content

Stop sending decided message #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alan-ssvlabs wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Stop sending decided message #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d1fa87
stop sending decided message
alan-ssvlabs Jun 5, 2025
a790789
spec -> phase0
alan-ssvlabs Jul 9, 2025
f5fc605
resolve conflicts
alan-ssvlabs Jul 9, 2025
aafe746
merge with main
alan-ssvlabs Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions qbft/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,6 @@ func (c *Controller) UponExistingInstanceMsg(msg *ProcessingMessage) (*types.Sig
return nil, nil
}

if err := c.broadcastDecided(decidedMsg); err != nil {
// no need to fail processing instance deciding if failed to save/ broadcast
fmt.Printf("%s\n", err.Error())
}
return decidedMsg, nil
}

Expand Down Expand Up @@ -169,15 +165,6 @@ func (c *Controller) forceStopAllInstanceExceptCurrent() {
}
}

func (c *Controller) broadcastDecided(aggregatedCommit *types.SignedSSVMessage) error {

if err := c.GetConfig().GetNetwork().Broadcast(aggregatedCommit.SSVMessage.GetID(), aggregatedCommit); err != nil {
// We do not return error here, just Log broadcasting error.
return errors.Wrap(err, "could not broadcast decided")
}
return nil
}

func (c *Controller) GetConfig() IConfig {
return c.config
}
2 changes: 1 addition & 1 deletion qbft/messages_encoding.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion qbft/spectest/all_tests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ var AllTests = []tests.TestF{
commit.NoCommitQuorum,
commit.ForceStop,
commit.PostCutoff,
commit.SortedDecided,

roundchange.HappyFlow,
roundchange.WrongHeight,
Expand Down
Loading