Fix QBFT identifier length check

[MatheusFranco99]

Overview

This PR adds a check for the QBFT Identifier field to ensure it has length 56, and adjusts the tests accordingly.

This is a non-fork version of the better refactoring: #536

Closes #533

[alan-ssvlabs]

LGTM
Depends on #537 right?

[MatheusFranco99]

Depends on #537 right?

I believe not, as this shouldn't affect the round validation

[GalRogozinski]

Good job!

[y0sher]

lgtm

[AgeManning]

I have approved

[Copilot]

Pull Request Overview

This PR fixes the QBFT identifier length check by ensuring that the "Identifier" (and similarly, the "ID") fields in test JSON files are updated to the expected 56‐character value rather than the old, shorter encoded string. Key changes include updating all relevant test files to replace "AQIDBA==" with a new 56‐character literal and adjusting associated test expectations.

Reviewed Changes

Copilot reviewed 417 out of 417 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
qbft/controller decide wrong msg type.json	Updated identifier and ID values to the new 56‐character format
qbft/controller decide unknown signer.json	Updated identifier and ID values to the new 56‐character format
qbft/controller decide past instance.json	Updated identifier and ID and adjusted nested message fields accordingly
qbft/controller decide no quorum.json	Updated identifier and ID values to the new 56‐character format
qbft/controller decide late decided.json	Updated identifier and ID values as well as nested data fields
qbft/controller decide late decided smaller quorum.json	Updated identifier and ID values accordingly
qbft/controller decide late decided bigger quorum.json	Updated identifier and ID values accordingly
qbft/controller decide invalid value (should pass).json	Updated identifier and ID values accordingly
qbft/controller decide invalid msg.json	Updated identifier and ID values accordingly
qbft/controller decide invalid full data.json	Updated identifier and ID values accordingly
qbft/controller decide has quorum.json	Updated identifier and ID values accordingly
qbft/controller decide future instance.json	Updated identifier and ID values accordingly
qbft/controller decide duplicate signer.json	Updated identifier and ID values accordingly
qbft/controller decide duplicate msg.json	Updated identifier and ID values accordingly
qbft/controller decide current instance.json	Updated identifier and ID values accordingly

Comments suppressed due to low confidence (1)

qbft/spectest/generate/state_comparison/tests_ControllerSpecTest/qbft controller decide wrong msg type.json:3

• Verify that the new identifier string exactly meets the QBFT specification requirements (i.e. the correct length and encoding) to avoid potential mismatches in production.

"Identifier": "AQIDBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=",