Skip to content

Configure local_bridge_mtu network in docker-compose#20

Open
vaclav-ssvlabs wants to merge 1 commit intossvlabs:mainfrom
vaclav-ssvlabs:patch-1
Open

Configure local_bridge_mtu network in docker-compose#20
vaclav-ssvlabs wants to merge 1 commit intossvlabs:mainfrom
vaclav-ssvlabs:patch-1

Conversation

@vaclav-ssvlabs
Copy link
Copy Markdown

Added local_bridge_mtu network configuration to services.

Added local_bridge_mtu network configuration to services.
Copilot AI review requested due to automatic review settings October 5, 2025 10:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a custom user-defined bridge network with a reduced MTU and attaches services to it to standardize container networking.

  • Introduces a local_bridge_mtu network with MTU set to 1420.
  • Connects postgres, sync, and calc services to the new network.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread docker-compose.yml
local_bridge_mtu:
driver: bridge
driver_opts:
com.docker.network.driver.mtu: 1420
Copy link

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] driver_opts values are expected as strings in Compose; quote the MTU to avoid type coercion issues across different Compose implementations.

Suggested change
com.docker.network.driver.mtu: 1420
com.docker.network.driver.mtu: "1420"

Copilot uses AI. Check for mistakes.
Comment thread docker-compose.yml
Comment on lines +16 to +17
networks:
- local_bridge_mtu
Copy link

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Since all services are attached to the same network solely to apply the MTU, consider configuring the default network instead. This eliminates duplication and automatically applies to all services. Example: replace the bottom block with a 'default' network and remove the per-service 'networks' entries shown above.

Copilot uses AI. Check for mistakes.
Comment thread docker-compose.yml
Comment on lines +36 to +37
networks:
- local_bridge_mtu
Copy link

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Since all services are attached to the same network solely to apply the MTU, consider configuring the default network instead. This eliminates duplication and automatically applies to all services. Example: replace the bottom block with a 'default' network and remove the per-service 'networks' entries shown above.

Copilot uses AI. Check for mistakes.
Comment thread docker-compose.yml
Comment on lines +48 to +55
networks:
- local_bridge_mtu

networks:
local_bridge_mtu:
driver: bridge
driver_opts:
com.docker.network.driver.mtu: 1420
Copy link

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Since all services are attached to the same network solely to apply the MTU, consider configuring the default network instead. This eliminates duplication and automatically applies to all services. Example: replace the bottom block with a 'default' network and remove the per-service 'networks' entries shown above.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants