Skip to content

ci: add Docker Hub release workflow with ARM64 support#232

Merged
olegshmuelov merged 3 commits intomainfrom
feat/docker-hub-ci
Apr 13, 2026
Merged

ci: add Docker Hub release workflow with ARM64 support#232
olegshmuelov merged 3 commits intomainfrom
feat/docker-hub-ci

Conversation

@olegshmuelov
Copy link
Copy Markdown
Contributor

@olegshmuelov olegshmuelov commented Apr 6, 2026

Summary

  • Add .github/workflows/docker-release.yml — builds and pushes multi-arch (amd64 + arm64) Docker images to Docker Hub on v* tag push
  • Fix Dockerfile alpine base image SHA pin from amd64-only platform digest to manifest list digest, enabling ARM64 builds

Context

Supersedes the Docker Hub workflow portion of #218. The remaining changes in #218 (Makefile, README, GitLab CI) can be evaluated separately.

Finding

F-ssv-dkg-034: Docker Hub CI missing — no docker image published on tag

Test

  • Verified golang base image SHA is already a manifest list (multi-arch safe)
  • Verified alpine SHA was amd64-only; replaced with manifest list digest
  • Full validation requires a test tag push

UPDATE: Bumped Go 1.25.8 → 1.25.9 across ci.yml, releases.yml, Dockerfile, and go.mod to resolve 3 stdlib CVEs flagged by govulncheck (GO-2026-4947, GO-2026-4946, GO-2026-4870 — crypto/x509 and crypto/tls).

@olegshmuelov
Copy link
Copy Markdown
Contributor Author

@vaclav-ssvlabs This PR needs a DOCKERHUB_TOKEN secret to push images. Could you check if an org-level secret already exists, or add one? Happy to adjust the secret name if there's a preferred convention.

Comment thread Dockerfile
Comment thread .github/workflows/docker-release.yml Outdated
vaclav-ssvlabs
vaclav-ssvlabs previously approved these changes Apr 9, 2026
Copy link
Copy Markdown

@vaclav-ssvlabs vaclav-ssvlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, token was added to the repo as SSV_DKG_DOCKERHUB_TOKEN - so please adjust.

Only small note - do we want to also push ssvlabs/ssv-dkg:latest? As you mentioned in one of PRs for ssv-oracle, this could be dangerous in case we need to do a patch for an older release, and this would override the latest with an older version.

It is more of a question of workflow if this scenario can ever happen.

I assume the multi-platform CI is expected to work, as I didn't test this myself and assume it works.

nkryuchkov
nkryuchkov previously approved these changes Apr 9, 2026
@olegshmuelov olegshmuelov dismissed stale reviews from nkryuchkov and vaclav-ssvlabs via aa9b96e April 9, 2026 11:40
@olegshmuelov
Copy link
Copy Markdown
Contributor Author

LGTM, token was added to the repo as SSV_DKG_DOCKERHUB_TOKEN - so please adjust.

updated to SSV_DKG_DOCKERHUB_TOKEN.

Only small note - do we want to also push ssvlabs/ssv-dkg:latest? As you mentioned in one of PRs for ssv-oracle, this could be dangerous in case we need to do a patch for an older release, and this would override the latest with an older version.

It is more of a question of workflow if this scenario can ever happen.

I assume the multi-platform CI is expected to work, as I didn't test this myself and assume it works.

Keeping latest for now, consistent with ssv-oracle. If we ever need to patch an older release we can revisit, but for a DKG tool the scenario is unlikely.

@olegshmuelov olegshmuelov merged commit 7d9ead2 into main Apr 13, 2026
5 checks passed
@olegshmuelov olegshmuelov deleted the feat/docker-hub-ci branch April 13, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants