Security Review#98
Open
moshe-blox wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BLSToExecutionChangeCLI testsVoluntaryExitandDepositDataCLI testsGenesisValidatorsRoot()NetworkFromString_byteArray|_byteArray32|_byteArray96?TestBenchmarkBlockProposalseems to have changed from911ac2f6d74039279f16eee4cc46f4c6eea0ef9d18f0d9739b407c150c07ccb104c1c4b034ad46b25719bafc22fad05205975393000ea09636f5ce427814e2fe12ea72041099cc7f6ec249e504992dbf65e968ab448ddf4e124cbcbc722829b5toaab8d1dc7e9fdea39b9a46cde64759138372a8d1226d56d01fa9e2df9e45e39d67bacf5794bb6841f5ea143aa124a33211089d4cc045e0605380bf4ae03291b1ee8082e55274ce5dc513cc0bebdb8e8a5276ad39a0cea3edd321d9cf854f695cNote: While it's a phase0 block, which isn't going to be proposed anymore, I still think we should try to reproduce the previous signature.
Note: Altair & Bellatrix signatures have been preserved as they were.
Note: It's changed because its no longer possible to sign a block with a slot 1.
Note: Verified. It's a real block from Sepolia: https://sepolia.beaconcha.in/slot/1861337
signer/sign_bls_to_execution_change_test.go?Note: Specified in the comment above the signatures in the code.
Note: Fixed and switched back to old signature. Values in the test were incorrect.
slashing_protection/proposal_protection_test.goNote: Minimal non-slashable slot was increased from 1 to 2 during the Prysm depdendency removal.